Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embit version to latest (0.7.0) #258

Closed
ghost opened this issue Oct 4, 2023 · 5 comments
Closed

Update embit version to latest (0.7.0) #258

ghost opened this issue Oct 4, 2023 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Oct 4, 2023

It's been a while since our embit dependency was updated. Here's the latest tagged release:
https://github.com/diybitcoinhardware/embit/releases/tag/v0.7.0

Another reason to update is that I'd like to soon (™️) update the PSBT signing code to use the PSBTView which should solve OOM errors for large transactions (many inputs/signers).

@ghost ghost added this to the Next Release milestone Oct 5, 2023
@ghost ghost added the enhancement New feature or request label Oct 5, 2023
@odudex
Copy link
Member

odudex commented Oct 9, 2023

Apparently it's a smooth update, the only thing that should be updated together are descriptor receive/change pair notation, from {0,1} to <0;1> .

Not related to Embit but I don't know exactly why, I started to have issues on tests parsing UR_OUTPUT_MULTISIG_WALLET_DATA descriptors.
Tracked the error to module 'urtypes' has no attribute 'crypto'
And solved by changing urtypes with this

@tadeubas
Copy link
Contributor

tadeubas commented Oct 9, 2023

I saw the commit, it is just an import, test passing now, for me it is ok!

@odudex
Copy link
Member

odudex commented Oct 9, 2023

Yes, available to test on integrated_changes

@tadeubas
Copy link
Contributor

tadeubas commented Mar 14, 2024

Can we consider this done in release 24.03.0 ?

@odudex
Copy link
Member

odudex commented Mar 14, 2024

Yes, done in Release v24.03.0

@odudex odudex closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants