Simplified translations #445
Conversation
src/krux/pages/tiny_seed.py
Outdated
| @@ -179,7 +179,7 @@ def print_tiny_seed(self): | |||
| pad_y = 8 # 2mm*8px | |||
| self.ctx.display.clear() | |||
| self.ctx.display.draw_hcentered_text( | |||
| t("Printing") + " ...", self.ctx.display.height() // 2 | |||
| t("Printing") + "..", self.ctx.display.height() // 2 | |||
There was a problem hiding this comment.
I like this pattern (if it works in all languages "..")
There was a problem hiding this comment.
We have been using this 2 dots pattern since first version of Krux!
https://github.com/selfcustody/krux/blob/v22.03.0/i18n/translations/en-US.json
There was a problem hiding this comment.
I meant the t("In the act of doing") + ".." vs t("In the act of doing..") pattern.
There was a problem hiding this comment.
But Jeff's file (first version of Krux) doesn't distinguish between going to do or doing, see examples below:
Checking receive address %d for match..
Loading..
Shutting down..
Updating bootloader..
Upgrading firmware..
Backing up bootloader..
There was a problem hiding this comment.
Sorry! I saw what you mean now... it is the separation of the ponctuation from the word... I think we can't do that. I will change the above
|
This pr has:
Each translator file has:
green checks Wow! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #445 +/- ##
===========================================
+ Coverage 94.20% 94.21% +0.01%
===========================================
Files 59 59
Lines 7264 7245 -19
===========================================
- Hits 6843 6826 -17
+ Misses 421 419 -2 ☔ View full report in Codecov by Sentry. |
…e specific line of the code
|
Thank you! |
Description
Removing unnecessary translations, merging others to simplify the translation process and also to reduce a little the firmware size
What is the purpose of this pull request?