Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Data proxy registration should include chain-id in the hash #37

Closed
2 tasks
Thomasvdam opened this issue Dec 30, 2024 · 0 comments · Fixed by #38
Closed
2 tasks

✨ Data proxy registration should include chain-id in the hash #37

Thomasvdam opened this issue Dec 30, 2024 · 0 comments · Fixed by #38
Assignees
@Thomasvdam
Labels
type: feature ✨ New feature or request

Comments

@Thomasvdam
Copy link
Member

Thomasvdam commented Dec 30, 2024 •
edited
Loading

✨ Feature

The data proxy registration TX should include the chain-id in the payload when verifying the signature.

Motivation

Right now there's nothing stopping a malicious actor from taking a RegisterDataProxy message from devnet (or eventually testnet) and submitting it on mainnet in order to squat that public key. While data-proxy operators are encouraged to run different keys for different environments we should nevertheless protect them against mistakes as much as possible.

Implementation

See sedaprotocol/seda-chain#455 for the chain side.

  • Ensure that the payload computation is the same as it is in the chain repository.
  • Add chain id to the payload before generating the signature.
@Thomasvdam Thomasvdam added the type: feature ✨ New feature or request label Dec 30, 2024
@Thomasvdam Thomasvdam mentioned this issue Dec 30, 2024
Closed
2 tasks
@Thomasvdam Thomasvdam self-assigned this Jan 6, 2025
Thomasvdam added a commit that referenced this issue Jan 6, 2025
@Thomasvdam
feat(data-proxy)!: add chain-id to signed registration payload
6183b93 
This prevents replay attacks between different networks.

Closes: #37
@Thomasvdam Thomasvdam mentioned this issue Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thomasvdam Thomasvdam

Labels
type: feature ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add chain-id to signed registration payload sedaprotocol/seda-data-proxy
1 participant
@Thomasvdam