Add chain-id to signed registration payload #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranklinWaller
approved these changes
Jan 6, 2025
This prevents replay attacks between different networks. Closes: #37
Thomasvdam
force-pushed
the
feat/data-proxy-chain-id
branch
from
6183b93 to
8220fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This prevents replay attacks between different networks.
Explanation of Changes
Also included client side address validation to help users spot errors sooner.
Testing
Generated new test vectors for sedaprotocol/seda-chain#457 with the mainnet configuration.
Related PRs and Issues
Closes: #37