Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Data proxy registration should include chain-id in the hash #455

Closed
2 tasks
Thomasvdam opened this issue Dec 30, 2024 · 0 comments · Fixed by #457
Closed
2 tasks

✨ Data proxy registration should include chain-id in the hash #455

Thomasvdam opened this issue Dec 30, 2024 · 0 comments · Fixed by #457
Assignees
Labels
type: feature ✨ New feature or request

Comments

@Thomasvdam
Copy link
Member

Thomasvdam commented Dec 30, 2024

✨ Feature

The data proxy registration TX should include the chain-id in the payload when verifying the signature.

Motivation

Right now there's nothing stopping a malicious actor from taking a RegisterDataProxy message from devnet (or eventually testnet) and submitting it on mainnet in order to squat that public key. While data-proxy operators are encouraged to run different keys for different environments we should nevertheless protect them against mistakes as much as possible.

Implementation

See sedaprotocol/seda-data-proxy#37 for the data-proxy side.

  • Ensure that the payload computation is the same as it is in the data proxy repository.
  • Add chain id to the payload before verifying the signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant