Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: copy overlays from midstream-v1.2.2 #162

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

lance
Copy link
Member

@lance lance commented Nov 20, 2023

Since we are foregoing the use of update-to-head.sh for this next release, these overlays only need to be applied once, when the branch is created.

Since we are foregoing the use of update-to-head.sh for this next
release, these overlays only need to be applied once, when the branch is
created.

Signed-off-by: Lance Ball <[email protected]>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JasonPowr can you please confirm these changes as applied to the upstream v1.3.3 tag?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep these changes still seem fine, these just relate to the rekor e2e tests, which are not running atm.

Copy link

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira, lance

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gregory-Pereira Gregory-Pereira merged commit a65cf4a into securesign:redhat-v1.3 Nov 21, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants