Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created midstream branch, modified patchfile #161

Conversation

Gregory-Pereira
Copy link

Not sure if I am doing this correctly. I created a new branch midstream-v1.3.0 from midstream-v1.2.2 and pushed that branch directly to securesign/rekor. Then I made the changes to upgrade the patchfile and included the steps I did to produce this change as an example.

@openshift-ci openshift-ci bot requested review from lkatalin and tommyd450 November 19, 2023 16:28
Copy link

openshift-ci bot commented Nov 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira
Once this PR has been reviewed and has the lgtm label, please assign lance for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance
Copy link
Member

lance commented Nov 20, 2023

@Gregory-Pereira since we are not using the midstream branch any longer, I think we don't need this. The changes in #162 apply directly to the release branch. I am going to close this PR, but thanks for being so proactive about it!

@lance lance closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants