Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: client and store interface #1160

Merged
merged 4 commits into from
Sep 17, 2024
Merged

refactor: client and store interface #1160

merged 4 commits into from
Sep 17, 2024

Conversation

dkonieczek
Copy link
Contributor

No description provided.

@dkonieczek dkonieczek requested a review from korgon September 10, 2024 21:20
@dkonieczek dkonieczek linked an issue Sep 10, 2024 that may be closed by this pull request
Additional Interface Cleanup #1147
Open
korgon
korgon approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@korgon korgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must be careful with regards to the breaking changes to the beforeSearch, afterSearch and afterStore middleware events.

@dkonieczek dkonieczek merged commit 496994f into templates Sep 17, 2024
1 check passed
@dkonieczek dkonieczek deleted the client-interface-refactor branch September 17, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korgon korgon korgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional Interface Cleanup
2 participants
@dkonieczek @korgon