You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the move to 1.0 we need to ensure our external interfaces are in a good state. Some interfaces that could use work are listed below and they are all pretty related; there may be more interfaces that could use adjusting.
Client
The autocomplete, search, finder and recommend methods return multiple API results, but they do it differently - we should be consistent with the response format. I am leaning more towards returning an object with the different response data but we could stick with the Promise.all array format as well - either way consistency is important here.
Changes to the Client above would necessitate changes to the Mock for it.
MockData
Similarly to the MockClient changes to MockData would be necessary, as currently the meta response is added into the API response - we would want to clean this up.
Controller search methods
Changes to all of the above would necessitate changes to the controller search methods as well as the associated store update methods; these would need to be refactored to separate out multiple API responses instead of merging them.
The text was updated successfully, but these errors were encountered:
With the move to
1.0
we need to ensure our external interfaces are in a good state. Some interfaces that could use work are listed below and they are all pretty related; there may be more interfaces that could use adjusting.Client
The
autocomplete
,search
,finder
andrecommend
methods return multiple API results, but they do it differently - we should be consistent with the response format. I am leaning more towards returning an object with the different response data but we could stick with thePromise.all
array format as well - either way consistency is important here.MockClient
Changes to the
Client
above would necessitate changes to the Mock for it.MockData
Similarly to the
MockClient
changes toMockData
would be necessary, as currently the meta response is added into the API response - we would want to clean this up.Controller
search
methodsChanges to all of the above would necessitate changes to the controller
search
methods as well as the associated storeupdate
methods; these would need to be refactored to separate out multiple API responses instead of merging them.The text was updated successfully, but these errors were encountered: