Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit renamed Cargo.lock file #856

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Commit renamed Cargo.lock file #856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,14 @@ jobs:
rustup override set ${{ env.rust_min }}
- name: Print Rust version
run: rustc --version
- name: Use MSRV Cargo.lock
run: mv Cargo.lock.msrv Cargo.lock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more request: could you add the --frozen flag to the invocations of cargo check in the min_rust job? This should assert that cargo doesn't modify the lockfile due to some reason not accounted by us.

- name: MSRV cargo check with features
run: cargo check --verbose --all-targets
run: cargo check --verbose --all-targets --locked
- name: MSRV cargo check without features
run: cargo check --verbose --all-targets --manifest-path "scylla/Cargo.toml"
run: cargo check --verbose --all-targets --locked --manifest-path "scylla/Cargo.toml"
- name: MSRV cargo check scylla-cql
run: cargo check --verbose --all-targets --manifest-path "scylla-cql/Cargo.toml"
run: cargo check --verbose --all-targets --locked --manifest-path "scylla-cql/Cargo.toml"

# Tests that docstrings generate docs without warnings
cargo_docs:
Expand Down
Loading