Commit renamed Cargo.lock file #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need something similar for Scylla itself? |
No, Scylla doesn't have this concern because we use a frozen toolchain and already commits |
piodul
approved these changes
Oct 26, 2023
piodul
reviewed
Oct 26, 2023
| @@ -60,6 +60,8 @@ jobs: | |||
| rustup override set ${{ env.rust_min }} | |||
| - name: Print Rust version | |||
| run: rustc --version | |||
| - name: Use MSRV Cargo.lock | |||
| run: mv Cargo.lock.msrv Cargo.lock | |||
There was a problem hiding this comment.
One more request: could you add the --frozen flag to the invocations of cargo check in the min_rust job? This should assert that cargo doesn't modify the lockfile due to some reason not accounted by us.
Lorak-mmk
force-pushed
the
fix_toml_datetime
branch
2 times, most recently
from
226dc9e to
194ed99
Compare
It will be used by min_rust workflow to build and check with our MSRV to prevent errors from packages updating their MSRV.
Lorak-mmk
force-pushed
the
fix_toml_datetime
branch
from
194ed99 to
5b0096b
Compare
piodul
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be used by min_rust workflow to build and check with our MSRV to prevent errors from packages updating their MSRV.
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.