-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to build image with custom gocql version #143
Conversation
go mod tidy | ||
|
||
@echo "Building Docker image with tag ${IMAGE_TAG}" | ||
docker build -f ${DOCKERFILE_PATH} . -t ${IMAGE_TAG} --build-arg version=${SCYLLA_BENCH_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use docker, run whole thing plain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SCT uses scylla-bench as a docker image.
And the original idea, as I understand, is to run SCT longevities: https://github.com/scylladb/gocql/pull/260/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how
Don't I have to use docker build to then run docker push and actually push docker image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SCT uses scylla-bench as a docker image. And the original idea, as I understand, is to run SCT longevities: https://github.com/scylladb/gocql/pull/260/files
exactly
|
||
# Default variables | ||
DOCKERFILE_PATH ?= Dockerfile | ||
SCYLLA_BENCH_VERSION ?= tags/v0.1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it is good idea to have a default for the scylla-bench version.
It is easy to get unexpected s-b version in a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to get the latest easily?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no latest
tag.
I made this statement assuming this workflow is going to be used with specific PRs.
So, if you are sure that specific PRs won't get problems having this default then ok, keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is going to be used with specific PRs, I just thought that in most cases we want to use the latest tag and it would be easier to update it in one place here than in every place that is going to use this Makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"master" branch should solve that need, if I understood everything correctly.
faddb7a
to
b70d508
Compare
Implemented in #144 |
As per @dkropachev request I moved logic with building image with custom gocql version to
scylla-bench
repo to be able to replace:with
in
gocql
extended CIscylladb/gocql#260 (comment)