-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github workflow running jenkins job #260
Conversation
New workflow won't be running in CI in this PR, because it uses Things to be changed:
To check if the |
- name: Replace gocql with the PR version | ||
run: | | ||
cd scylla-bench | ||
go mod edit -replace github.com/gocql/gocql=../gocql | ||
go mod tidy | ||
|
||
- name: Build and push Scylla-bench Docker Image | ||
run: | | ||
cd scylla-bench | ||
export SCYLLA_BENCH_VERSION=tags/v0.1.22 | ||
export NAME="${{ github.event.pull_request.head.ref }}" | ||
export SCYLLA_BENCH_DOCKER_IMAGE=scylladb/gocql-extended-ci:scylla-bench-${NAME} | ||
docker build -f ../gocql/.github/workflows/Dockerfile . -t ${SCYLLA_BENCH_DOCKER_IMAGE} --build-arg version=$SCYLLA_BENCH_VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this logic to scylla-bench
repo.
So that here it would look like:
- name: Build and push scylla-bench image
run: |
cd scylla-bench
GOCQL_COMMIT_ID="${{ github.event.pull_request.head.ref }}" IMAGE_TAG="scylladb/gocql-extended-ci:scylla-bench-${NAME}" make build-image-with-custom-gocql-commit
docker push "scylladb/gocql-extended-ci:scylla-bench-${NAME}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repository: ${{ github.event.pull_request.head.repo.full_name }} | ||
ref: ${{ github.event.pull_request.head.ref }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it default ? can't you just use path: gocql
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to be not, look: https://github.com/scylladb/gocql/pull/255/checks
Or do you mean I should add path: gocql
in some other place?
This workflow pushes scylla-bench docker image using gocql version from the PR and triggers jenkins job that uses this image of scylla-bench.
7439ea6
to
cffde97
Compare
18fed30
to
15245cd
Compare
I went with @Lorak-mmk advice #204 (comment) |
This workflow pushes scylla-bench docker image using gocql version from the PR and triggers jenkins job that uses this image of scylla-bench.