[To split] Refactor BaseFold and add some features. #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current benchmark results for simple batch (just after refactoring, no skipping rounds yet): Polynomials size: 64 polys, 20 num of variables.
|
|
Current benchmark results for batch vlop (no skipping rounds yet): Polynomial size: 8 groups, each group has 8 polynomials, with number of variables 20, 19, 18, ..., 13, respectively.
|
|
Current benchmark results for simple batch (after refactoring, with new Poseidon hash function, no skipping rounds yet): Polynomials size: 64 polys, 20 num of variables.
|
|
After changing query number to 200:
|
matthiasgoergens
requested changes
Oct 30, 2024
yczhangsjtu
added a commit
that referenced
this pull request
Nov 5, 2024
Extracting a small PR from #294. The random generator is used only when the encoding scheme is Basecode, and not used for RS code. So remove it from the type parameter for Basefold, i.e., `Basefold<E, Spec, Rng>` is replaced with `Basefold<E, Spec>` to make the API simpler. Fix it to `ChaCha8Rng` in the implementation of Basecode.
yczhangsjtu
changed the title
This was referenced Nov 5, 2024
hero78119
added a commit
that referenced
this pull request
Nov 26, 2024
Extract a small independent change from #294 Co-authored-by: Ming <[email protected]>
yczhangsjtu
added a commit
that referenced
this pull request
Nov 28, 2024
Extracting small PR from #294 Refactor the test code in `mpcs/src/lib.rs`. Define some utility functions to simplify the tests. Also merged the test functions in `mpcs/src/basefold.rs`.
yczhangsjtu
added a commit
that referenced
this pull request
Nov 28, 2024
Extracting small PR from #294. The two benchmarks `benches_commit_verify_rs` and `benches_commit_verify_basecode` are similar, differing only in the choice of parameter. Merge them into one benchmark file. Also simplify the codes using the test utility functions introduced in #552 Waiting for #552 to merge. --------- Co-authored-by: Matthias Görgens <[email protected]>
|
Too big PR. Splitting gradually (but not top priority for now), close first. |
yczhangsjtu
added a commit
that referenced
this pull request
Nov 28, 2024
Extracting small PRs from #294 There was an implementation of Iterator for iterating through a `FieldType`. Turns out that it can be replaced with existing tools in `iter_tools`. This proposes the new implementation. Also added some other utility functions for type conversion between `FieldType` and `Vec<E>`, to avoid `match field_type` everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massively refactored the code. Eliminate the repetitive codes.
Add features:
Skipping rounds optimization (consider canceling this because it's complex to implement, but the benefit is small since proving time is only 200ms now.)API change:
batch_open/verifyintobatch_vlmp_*wherevlmpstands for "polys of Variable Length opened at Multiple Points".batch_vlop_open/verifywherevlopstands for "polys of Variable Length opened at One Points".Rngfrom the template parameters forBasefold.