Refactor BaseFold hashing benchmark. #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yczhangsjtu
changed the title
…tor-benchmark-hashing
hero78119
approved these changes
Nov 26, 2024
| @@ -5,28 +5,19 @@ use goldilocks::Goldilocks; | |||
| use mpcs::util::hash::{Digest, hash_two_digests}; | |||
| use poseidon::poseidon_hash::PoseidonHash; | |||
|
|
|||
| fn random_ceno_goldy() -> Goldilocks { | |||
| Goldilocks::random(&mut test_rng()) | |||
There was a problem hiding this comment.
A better style probably been changed to call test_rng() once and reused it instead of instantiate & drop immediately for every field element, which is very costly.
The good thing is it's put in bench "setup", at least not distorted benchmark results.
Not directly related to this PR, as it already there for long time. overall LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract a small independent change from #294