-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#174 generalize mul op #200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimiWu123
force-pushed
the
feat/#174-generalize-mul-op
branch
from
September 10, 2024 06:27
bad8dce
to
9ff1967
Compare
KimiWu123
changed the title
[WIP] Feat/#174 generalize mul op
Feat/#174 generalize mul op
Sep 10, 2024
KimiWu123
force-pushed
the
feat/#174-generalize-mul-op
branch
from
September 10, 2024 07:22
9ff1967
to
b167db6
Compare
hero78119
reviewed
Sep 10, 2024
hero78119
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!!
reporting an edge case
#[test]
fn test_mul64_16_w_overflow_test() {
let wit_a = vec![0, 0, 0, u16::MAX as u64];
let wit_b = vec![0, 0, 0, u16::MAX as u64];
let wit_c = vec![0, 0, 0, 0];
let wit_carries = vec![0, 0, 0];
let witness_values = [wit_a, wit_b, wit_c, wit_carries].concat();
verify::<64, 16, E>(witness_values, false);
}
and plan to further investigate in #98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed item3 in #174