Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#174 generalize mul op #200

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Feat/#174 generalize mul op #200

merged 8 commits into from
Sep 11, 2024

Conversation

KimiWu123
Copy link
Contributor

closed item3 in #174

@KimiWu123 KimiWu123 self-assigned this Sep 9, 2024
@KimiWu123 KimiWu123 force-pushed the feat/#174-generalize-mul-op branch from bad8dce to 9ff1967 Compare September 10, 2024 06:27
@KimiWu123 KimiWu123 changed the title [WIP] Feat/#174 generalize mul op Feat/#174 generalize mul op Sep 10, 2024
@KimiWu123 KimiWu123 marked this pull request as ready for review September 10, 2024 06:27
@KimiWu123 KimiWu123 requested a review from hero78119 September 10, 2024 06:43
Copy link
Collaborator

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!!

reporting an edge case

#[test]
        fn test_mul64_16_w_overflow_test() {
            let wit_a = vec![0, 0, 0, u16::MAX as u64];
            let wit_b = vec![0, 0, 0, u16::MAX as u64];
            let wit_c = vec![0, 0, 0, 0];
            let wit_carries = vec![0, 0, 0];
            let witness_values = [wit_a, wit_b, wit_c, wit_carries].concat();
            verify::<64, 16, E>(witness_values, false);
        }

and plan to further investigate in #98

@hero78119 hero78119 merged commit 5a68423 into master Sep 11, 2024
4 checks passed
@hero78119 hero78119 deleted the feat/#174-generalize-mul-op branch September 11, 2024 04:02
hero78119 pushed a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants