Skip to content

Add preflight logging #41

Add preflight logging

Add preflight logging #41

GitHub Actions / Clippy Output succeeded Dec 21, 2023 in 0s

Clippy Output

12 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 12
Note 0
Help 0

Versions

  • rustc 1.76.0-nightly (5ac4c8a63 2023-12-20)
  • cargo 1.76.0-nightly (1a2666ddd 2023-12-17)
  • clippy 0.1.76 (5ac4c8a 2023-12-20)

Annotations

Check warning on line 9 in scripty_commands/src/cmds/admin/shutdown.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

unused variable: `guild_id`

warning: unused variable: `guild_id`
 --> scripty_commands/src/cmds/admin/shutdown.rs:9:7
  |
9 |     for (guild_id, call) in songbird.iter() {
  |          ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_guild_id`

Check warning on line 5 in scripty_commands/src/cmds/admin/shutdown.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

unused variable: `msg`

warning: unused variable: `msg`
 --> scripty_commands/src/cmds/admin/shutdown.rs:5:6
  |
5 |     let msg = ctx.say("shutting down").await?;
  |         ^^^ help: if this is intentional, prefix it with an underscore: `_msg`
  |
  = note: `#[warn(unused_variables)]` on by default

Check warning on line 70 in scripty_bot_utils/src/dm_support.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

unnecessary closure used to substitute value for `Option::None`

warning: unnecessary closure used to substitute value for `Option::None`
  --> scripty_bot_utils/src/dm_support.rs:66:5
   |
66 | /                 message
67 | |                     .author
68 | |                     .global_name
69 | |                     .as_ref()
70 | |                     .unwrap_or_else(|| &message.author.name)
   | |______________________--------------------------------------^
   |                        |
   |                        help: use `unwrap_or(..)` instead: `unwrap_or(&message.author.name)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
   = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default

Check warning on line 41 in scripty_audio_handler/src/events/voice_tick.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

this function has too many arguments (12/7)

warning: this function has too many arguments (12/7)
  --> scripty_audio_handler/src/events/voice_tick.rs:28:1
   |
28 | / pub async fn voice_tick(
29 | |     voice_data: VoiceTick,
30 | |     ssrc_state: Arc<SsrcMaps>,
31 | |     guild_id: GuildId,
...  |
40 | |     translate: Arc<AtomicBool>,
41 | | ) {
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 27 in scripty_audio_handler/src/events/driver_disconnect.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

this function has too many arguments (9/7)

warning: this function has too many arguments (9/7)
  --> scripty_audio_handler/src/events/driver_disconnect.rs:17:1
   |
17 | / pub async fn driver_disconnect(
18 | |     guild_id: GuildId,
19 | |     reason: Option<DisconnectReason>,
20 | |     ctx: Context,
...  |
26 | |     seen_users: SeenUsers,
27 | | ) {
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 81 in scripty_audio_handler/src/audio_handler.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
  --> scripty_audio_handler/src/audio_handler.rs:72:2
   |
72 | /     pub async fn new(
73 | |         guild_id: GuildId,
74 | |         webhook: Webhook,
75 | |         context: Context,
...  |
80 | |         automod_server_cfg: AutomodServerConfig,
81 | |     ) -> Result<Self, sqlx::Error> {
   | |__________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 425 in scripty_audio_handler/src/events/voice_tick.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

function `handle_error` is never used

warning: function `handle_error` is never used
   --> scripty_audio_handler/src/events/voice_tick.rs:425:4
    |
425 | fn handle_error(error: ModelError, ssrc: u32) -> ExecuteWebhook {
    |    ^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 379 in scripty_audio_handler/src/events/voice_tick.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

value assigned to `final_transcript` is never read

warning: value assigned to `final_transcript` is never read
   --> scripty_audio_handler/src/events/voice_tick.rs:379:10
    |
379 |     let mut final_transcript = None;
    |             ^^^^^^^^^^^^^^^^
    |
    = help: maybe it is overwritten before being read?
    = note: `#[warn(unused_assignments)]` on by default

Check warning on line 111 in scripty_audio_handler/src/events/voice_tick.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

unused variable: `auto_detect_lang`

warning: unused variable: `auto_detect_lang`
   --> scripty_audio_handler/src/events/voice_tick.rs:111:3
    |
111 |         auto_detect_lang,
    |         ^^^^^^^^^^^^^^^^ help: try ignoring the field: `auto_detect_lang: _`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 76 in scripty_data_storage/src/cache/voice.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`

warning: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
  --> scripty_data_storage/src/cache/voice.rs:71:52
   |
71 |       match scripty_redis::run_transaction("GET", |con| {
   |  _______________________________________________________^
72 | |         con.arg(format!(
73 | |             "user:{{{}}}:store_audio",
74 | |             hex::encode(user_id.clone())
75 | |         ));
76 | |     })
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions

Check warning on line 76 in scripty_data_storage/src/cache/text.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`

warning: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
  --> scripty_data_storage/src/cache/text.rs:71:52
   |
71 |       match scripty_redis::run_transaction("GET", |con| {
   |  _______________________________________________________^
72 | |         con.arg(format!(
73 | |             "user:{{{}}}:store_msgs",
74 | |             hex::encode(user_id.clone())
75 | |         ));
76 | |     })
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions
   = note: `#[warn(clippy::blocks_in_conditions)]` on by default

Check warning on line 82 in scripty_automod/src/types.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
  --> scripty_automod/src/types.rs:73:2
   |
73 | /     pub fn new(
74 | |         guild_id: u64,
75 | |         internal_id: i32,
76 | |         enabled: bool,
...  |
81 | |         auto_join_voice: bool,
82 | |     ) -> Self {
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default