Add preflight logging #41
tazz4843Annotations
22 warnings
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
unused variable: `guild_id`:
scripty_commands/src/cmds/admin/shutdown.rs#L9
warning: unused variable: `guild_id`
--> scripty_commands/src/cmds/admin/shutdown.rs:9:7
|
9 | for (guild_id, call) in songbird.iter() {
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_guild_id`
|
|
unused variable: `msg`:
scripty_commands/src/cmds/admin/shutdown.rs#L5
warning: unused variable: `msg`
--> scripty_commands/src/cmds/admin/shutdown.rs:5:6
|
5 | let msg = ctx.say("shutting down").await?;
| ^^^ help: if this is intentional, prefix it with an underscore: `_msg`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unnecessary closure used to substitute value for `Option::None`:
scripty_bot_utils/src/dm_support.rs#L66
warning: unnecessary closure used to substitute value for `Option::None`
--> scripty_bot_utils/src/dm_support.rs:66:5
|
66 | / message
67 | | .author
68 | | .global_name
69 | | .as_ref()
70 | | .unwrap_or_else(|| &message.author.name)
| |______________________--------------------------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(&message.author.name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
|
|
this function has too many arguments (12/7):
scripty_audio_handler/src/events/voice_tick.rs#L28
warning: this function has too many arguments (12/7)
--> scripty_audio_handler/src/events/voice_tick.rs:28:1
|
28 | / pub async fn voice_tick(
29 | | voice_data: VoiceTick,
30 | | ssrc_state: Arc<SsrcMaps>,
31 | | guild_id: GuildId,
... |
40 | | translate: Arc<AtomicBool>,
41 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
|
this function has too many arguments (9/7):
scripty_audio_handler/src/events/driver_disconnect.rs#L17
warning: this function has too many arguments (9/7)
--> scripty_audio_handler/src/events/driver_disconnect.rs:17:1
|
17 | / pub async fn driver_disconnect(
18 | | guild_id: GuildId,
19 | | reason: Option<DisconnectReason>,
20 | | ctx: Context,
... |
26 | | seen_users: SeenUsers,
27 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
|
this function has too many arguments (8/7):
scripty_audio_handler/src/audio_handler.rs#L72
warning: this function has too many arguments (8/7)
--> scripty_audio_handler/src/audio_handler.rs:72:2
|
72 | / pub async fn new(
73 | | guild_id: GuildId,
74 | | webhook: Webhook,
75 | | context: Context,
... |
80 | | automod_server_cfg: AutomodServerConfig,
81 | | ) -> Result<Self, sqlx::Error> {
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
function `handle_error` is never used:
scripty_audio_handler/src/events/voice_tick.rs#L425
warning: function `handle_error` is never used
--> scripty_audio_handler/src/events/voice_tick.rs:425:4
|
425 | fn handle_error(error: ModelError, ssrc: u32) -> ExecuteWebhook {
| ^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
value assigned to `final_transcript` is never read:
scripty_audio_handler/src/events/voice_tick.rs#L379
warning: value assigned to `final_transcript` is never read
--> scripty_audio_handler/src/events/voice_tick.rs:379:10
|
379 | let mut final_transcript = None;
| ^^^^^^^^^^^^^^^^
|
= help: maybe it is overwritten before being read?
= note: `#[warn(unused_assignments)]` on by default
|
|
unused variable: `auto_detect_lang`:
scripty_audio_handler/src/events/voice_tick.rs#L111
warning: unused variable: `auto_detect_lang`
--> scripty_audio_handler/src/events/voice_tick.rs:111:3
|
111 | auto_detect_lang,
| ^^^^^^^^^^^^^^^^ help: try ignoring the field: `auto_detect_lang: _`
|
= note: `#[warn(unused_variables)]` on by default
|
|
in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`:
scripty_data_storage/src/cache/voice.rs#L71
warning: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
--> scripty_data_storage/src/cache/voice.rs:71:52
|
71 | match scripty_redis::run_transaction("GET", |con| {
| _______________________________________________________^
72 | | con.arg(format!(
73 | | "user:{{{}}}:store_audio",
74 | | hex::encode(user_id.clone())
75 | | ));
76 | | })
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions
|
|
in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`:
scripty_data_storage/src/cache/text.rs#L71
warning: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
--> scripty_data_storage/src/cache/text.rs:71:52
|
71 | match scripty_redis::run_transaction("GET", |con| {
| _______________________________________________________^
72 | | con.arg(format!(
73 | | "user:{{{}}}:store_msgs",
74 | | hex::encode(user_id.clone())
75 | | ));
76 | | })
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions
= note: `#[warn(clippy::blocks_in_conditions)]` on by default
|
|
this function has too many arguments (8/7):
scripty_automod/src/types.rs#L73
warning: this function has too many arguments (8/7)
--> scripty_automod/src/types.rs:73:2
|
73 | / pub fn new(
74 | | guild_id: u64,
75 | | internal_id: i32,
76 | | enabled: bool,
... |
81 | | auto_join_voice: bool,
82 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|