-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#51 Enable completion command to generate shell completions #60
#51 Enable completion command to generate shell completions #60
Conversation
Signed-off-by: Somsubhra Bairi <[email protected]>
Signed-off-by: Somsubhra Bairi <[email protected]>
Thanks for your contribution, @Somsubhra, much appreciated. From a usability/end-user perspective this LGTM, but I would love to get the review from @delca85 or @astromechza on this. For example, in |
Makes sense, I will add tests. |
Signed-off-by: Somsubhra Bairi <[email protected]>
Done - tests are added and they are passing in CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Somsubhra!
LGTM
Let's have a second pair of eyes on this, thanks for your review @delca85 in case we are missing anything here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
#51 Enable completion command to generate shell completions
Description
This PR enables the completion command in score-k8s to generate shell completions.
Command Description
Example
What does this PR do?
Remove the cobra configuration which hides the completion command
Types of changes
Checklist: