Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#51 Added docs for completion command in score-k8s #124

Merged

Conversation

Somsubhra
Copy link
Contributor

What is the motivation?

Added documentation for the completion command added to score-k8s to generate shell completions as a part of PR score-spec/score-k8s#60 Issue score-spec/score-k8s#51

What does this change do?

Add documentation for the completion command added to score-k8s

What is your testing strategy?

Is this related to any issues?

score-spec/score-k8s#51

Have you read the Contributing Guidelines?

@mathieu-benoit
Copy link
Contributor

Hi @Somsubhra, thanks for adding this, I'll review soon this other PR score-spec/score-k8s#51 as it's a dependencies on this one (and a release associated to this too).

In the meantime, we just merged this in main #123, could you please update your branch accordingly and also add this new command on this new page https://docs.score.dev/docs/score-implementation/score-k8s/cli/? Thanks!

@Somsubhra
Copy link
Contributor Author

@mathieu-benoit - updated the documentation on the new page. Thanks!

@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Oct 18, 2024

Thanks, @Somsubhra.

Now waiting for score-spec/score-k8s#60 to be completed, merged and released in order to proceed here.

@mathieu-benoit
Copy link
Contributor

New version of score-k8s including this feature now released: https://github.com/score-spec/score-k8s/releases/tag/0.1.14, let's merge this one now.

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathieu-benoit mathieu-benoit merged commit a0e7aca into score-spec:main Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants