-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes made for provisoners flag #221
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Score provides a developer-centric and platform-agnostic | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think @rabelmervin you should not add this file cause it's irrelevant to issue #220 |
||
# Workload specification to improve developer productivity and experience. | ||
# Score eliminates configuration management between local and remote environments. | ||
# | ||
# Specification reference: https://docs.score.dev/docs/reference/score-spec-reference/ | ||
--- | ||
|
||
# Score specification version | ||
apiVersion: score.dev/v1b1 | ||
|
||
metadata: | ||
name: example | ||
|
||
containers: | ||
hello-world: | ||
image: nginx:latest | ||
|
||
# Uncomment the following for a custom entrypoint command | ||
# command: [] | ||
|
||
# Uncomment the following for custom arguments | ||
# args: [] | ||
|
||
# Environment variables to inject into the container | ||
variables: | ||
EXAMPLE_VARIABLE: "example-value" | ||
|
||
service: | ||
ports: | ||
# Expose the http port from nginx on port 8080 | ||
www: | ||
port: 8080 | ||
targetPort: 80 | ||
|
||
resources: {} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Score provides a developer-centric and platform-agnostic | ||
# Workload specification to improve developer productivity and experience. | ||
# Score eliminates configuration management between local and remote environments. | ||
# | ||
# Specification reference: https://docs.score.dev/docs/reference/score-spec-reference/ | ||
--- | ||
|
||
# Score specification version | ||
apiVersion: score.dev/v1b1 | ||
|
||
metadata: | ||
name: example | ||
|
||
containers: | ||
hello-world: | ||
image: nginx:latest | ||
|
||
# Uncomment the following for a custom entrypoint command | ||
# command: [] | ||
|
||
# Uncomment the following for custom arguments | ||
# args: [] | ||
|
||
# Environment variables to inject into the container | ||
variables: | ||
EXAMPLE_VARIABLE: "example-value" | ||
|
||
service: | ||
ports: | ||
# Expose the http port from nginx on port 8080 | ||
www: | ||
port: 8080 | ||
targetPort: 80 | ||
|
||
resources: {} | ||
Comment on lines
+1
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same for this, If you want to add examples, you should refer to this and in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please move this functionality over to https://github.com/score-spec/score-go/blob/main/uriget/uriget.go#L155 as part of the file type getter? This is a good place to add unit tests too.
This is common functionality that we can use and document in all the consumers of this library. This would allow the uri to be documented as either:
file://-
or just-
.I can help get this turned around quickly :)