Changes made for provisoners flag #221
Conversation
|
Thanks, @rabelmervin! You need to sign your commits to have the DCO passing successfully on this PR:
|
Signed-off-by: rabelmervin <[email protected]>
|
Hello @mathieu-benoit @astromechza I have signed the commits and DCO is passed successfully :) Is there anything i can help you with ? |
|
hey, @rabelmervin I'm not a reviewer but can you also update the test case over here https://github.com/score-spec/score-compose/blob/main/internal/command/init_test.go#L79 |
| @@ -0,0 +1,35 @@ | |||
| # Score provides a developer-centric and platform-agnostic | |||
There was a problem hiding this comment.
I think @rabelmervin you should not add this file cause it's irrelevant to issue #220
Also, it is of no use.
| # Score provides a developer-centric and platform-agnostic | ||
| # Workload specification to improve developer productivity and experience. | ||
| # Score eliminates configuration management between local and remote environments. | ||
| # | ||
| # Specification reference: https://docs.score.dev/docs/reference/score-spec-reference/ | ||
| --- | ||
|
|
||
| # Score specification version | ||
| apiVersion: score.dev/v1b1 | ||
|
|
||
| metadata: | ||
| name: example | ||
|
|
||
| containers: | ||
| hello-world: | ||
| image: nginx:latest | ||
|
|
||
| # Uncomment the following for a custom entrypoint command | ||
| # command: [] | ||
|
|
||
| # Uncomment the following for custom arguments | ||
| # args: [] | ||
|
|
||
| # Environment variables to inject into the container | ||
| variables: | ||
| EXAMPLE_VARIABLE: "example-value" | ||
|
|
||
| service: | ||
| ports: | ||
| # Expose the http port from nginx on port 8080 | ||
| www: | ||
| port: 8080 | ||
| targetPort: 80 | ||
|
|
||
| resources: {} |
There was a problem hiding this comment.
Same for this, If you want to add examples, you should refer to this and in a separate PR.
|
Hi @7h3-3mp7y-m4n I'll the add the test functions and I'll remove that irrelevant files 👍 |
Initially the provisioners flag doesnt support local file and stdin. But now local and stdin added