Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comply with boost-histogram 1.4.0 #895

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

ikrommyd
Copy link
Collaborator

boost-histogram 1.4.0 now states that "filling an integer-based axis requires an integer array - a floating point array is disallowed (a single float was always disallowed), due to issues with rounding around 0". So, I add dtype=int to all ak.zeros_like and np.arange in analysis_tools.

@lgray
Copy link
Collaborator

lgray commented Sep 15, 2023

There's a broken test from awkward right now. I'll check that none of the associated tests for analysis tools are broken by this.

@ikrommyd
Copy link
Collaborator Author

ikrommyd commented Sep 16, 2023

I've only touched analysis_tools.py. I control-F'ed in vscode but couldn't find another such instance in the source code. Tests pass locally so unless we encounter another apple silicon vs x86 case it should be good.

@ikrommyd
Copy link
Collaborator Author

Touched a few more minor stuff since we're here.

@lgray lgray merged commit fa73cb5 into scikit-hep:master Sep 19, 2023
5 of 13 checks passed
@ikrommyd ikrommyd deleted the boost_histogram_compliance branch September 19, 2023 14:56
@ikrommyd ikrommyd restored the boost_histogram_compliance branch September 23, 2023 16:02
@ikrommyd ikrommyd deleted the boost_histogram_compliance branch September 23, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants