-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followup issue for new features to PackedSelection #848
Comments
I would also add "do another check for unnecessary |
I gave it a once-over before I merged it but sure. |
@lgray In #895, I've partially adressed the 2nd point, meaning I've reduced the number of compute calls in I've also checked again for unnecessary eager I'm planning to fully address the first 2 points in a separate PR. If tests are good, I'm fine with merging #895 |
We may wanna think about that a bit more. I'm still somewhat against calling computes for people unless it's really necessary, it introduce unexpected slowness. Is there any way we can reorganize things to return futures to the user for them to compute? |
The only computes are while saving arrays (where the user has the option to call compute later) and while printing statistics of the cutflow and N-1 selections. I guess we can also add the option to print later, or warn that this will compute the arrays on the spot. For saving, I just made the default to be |
I think this is done now. Reopen if not. |
Things to finish later for #797
.compute()
len()
calls on dak.ArraysThe text was updated successfully, but these errors were encountered: