Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webrtc adapter #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

frederikbosch
Copy link

@frederikbosch frederikbosch commented Jul 5, 2017

The adapter was quite some versions behind. The newer version also supports Safari (though it is still buggy). With the newer adapter version, we were receiving the permissions prompt multiple times due to the ensureAccess call.

p.s. great lib.

@robertfausk
Copy link

Ping @schmich

Will you merge this? I'm also looking forward to iOS compatibility. Maybe #54 is related.

@schmich
Copy link
Owner

schmich commented Jul 17, 2017

@robertfausk I have to apologize. I have been neglecting this project for some time, and it is in need of serious attention. I'm hoping to get some time this week to spend with this project.

It is likely that webrtc-adapter will become a peer dependency. Doing this puts more burden on clients, but it allows them to include their own version they might already be using, and it alleviates the need for this library to constantly update the dependent version. It is possible that a fully-bundled, standalone version could be produced as well.

Regardless, iOS/Safari support is essential, and I will be looking into that.

@robertfausk
Copy link

@schmich Let me know if you need some help.

@frederikbosch
Copy link
Author

@schmich Little advice from my side: if you have an open source project that needs attention, start by merging minor changes. The library is fine (actually it is great), no need for serious attention, or huge changes.

Myself, I have fallen more than once into the trap that I said that I should pay attention to some open source project, the result is almost always that you do not do anything at all. But maybe you are different!

@bchr02
Copy link

bchr02 commented Sep 16, 2017

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants