Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 11, Webpack and moar #78

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

PallasKatze
Copy link

@PallasKatze PallasKatze commented Sep 19, 2017

This PR incorporates some changes from already opened PRs and adds some more.

  • babel-polyfill replaced with transform runtime
  • webrtc-adapter shim removed from dependencies since there is no need to use this shim in most modern browsers (tested in latest Chrome Desktop, latest Opera, latest Firefox, Safari 11 beta 6). Edge and Chrome for Android (sic!) still need this shim (added a note to README).
  • Updated dependencies
  • Gulp now compiles files to ES5 upon release
  • Webpack compatibility without additional configuration options (like node)
  • It now works in Mobile Safari 11

Ref. /pull/48
Ref. /pull/49
Ref. /pull/55
Ref. /pull/63

Closes /issues/42
Closes /issues/47
Closes /issues/54

@mairh
Copy link

mairh commented Sep 19, 2017

@PallasKatze Since you have added a bunch of fixes in this PR. I would suggest you add the fix for iOS11 compatibility and rear camera fix too as discussed in the issue. #54

@PallasKatze
Copy link
Author

@mairh Will do this once I get an iOS update and test the fix

@mairh
Copy link

mairh commented Sep 19, 2017

Sure. If you are feeling impatient and want to test it sooner you can sign up for iOS 11 beta program and install the latest version https://beta.apple.com/sp/betaprogram/

@PallasKatze
Copy link
Author

Seems like I fixed the issue in Mobile Safari 11. Can anyone test and confirm this?

@PallasKatze PallasKatze changed the title Webpack compatibility and moar iOS 11, Webpack and moar Sep 20, 2017
@mairh
Copy link

mairh commented Sep 20, 2017

@PallasKatze I've tested it on iOS 11 safari (both iPhone and iPad) and it works nicely. One thing I would like to confirm if the back camera on mobile is inverted by default. Is it the intended behavior or should we have an option not to opt for the inverted camera option?

@PallasKatze
Copy link
Author

@mairh Thanks

One thing I would like to confirm if the back camera on mobile is inverted by default. Is it the intended behavior or should we have an option not to opt for the inverted camera option?

We already have mirror option to control this behavior.

@mairh
Copy link

mairh commented Sep 20, 2017

But it makes more sense to have the mirror option (default: true) only for the front-facing camera. On mobile (since the default is the back-facing camera) the mirror option should be set to false. Can you make that change? I think it could either go as default in camera.js or app.js (custom).

@PallasKatze
Copy link
Author

I'm not sure there is a simple way to determine whether the camera is front- or back-facing. Please open a new issue for you feature request.

@mairh
Copy link

mairh commented Sep 20, 2017

Seems like there is an issue for this already #70

@PallasKatze
Copy link
Author

@schmich any thoughts on this PR?

@PallasKatze
Copy link
Author

@mairh

I'm not sure there is a simple way to determine whether the camera is front- or back-facing

Okay, now I know how to do that. I'll take a look at #70 soon.

@anthonyyuan
Copy link

why do i not work it sucessful

@lorenzocavina-injenia
Copy link

lorenzocavina-injenia commented Oct 7, 2017

Hi @PallasKatze,
so as I may understand now instascan may work on Safari 11 too?

Thank you very much.

@rvlaskamp
Copy link

IOS11 Safari crashes after scanning 10 qrcodes. It reloads the page and all results are missing. Are you guys having the same issues or maybe it's an issue with my setup. I'm using Vue.JS. I initialize the camera if my app is mounted and the starting and stopping the camera if a qrcode is scanned. This works fine in Chrome Browser on MacOS, but in Safari on IOS11 it crashes infrequently.

@PallasKatze
Copy link
Author

@rvlaskamp I got a few crashes while testing this on iPhone 6. My assumptions: 1) It's a bug in Safari 11; 2) Safari runs out of memory and kills the tab. Anyway, we need to find a way to reduce memory consumption. Try increasing the scanPeriod value and test it again.

@exiva
Copy link

exiva commented Oct 22, 2017

Android fails out when trying to access the rear camera on this pull request with

Uncaught (in promise) NavigatorUserMediaErrorconstraintName: ""message: ""name: "TrackStartError"__proto__: NavigatorUserMediaError

with and without the webrtc-adapter. Front camera works fine.

@jscadden
Copy link

@exiva I get the same error. Were you able to find a solution?

@exiva
Copy link

exiva commented Nov 5, 2017

@jscadden No, I have not yet.

@nicolasjnm
Copy link

nicolasjnm commented Nov 14, 2017

Hi, I trying to select the rear camera on iOS and I still look the frontal camera. any ideas!?

@agusbrand
Copy link

Were anyone able to find a solution?
do you know any other good qr scanner library ?
Thanks!

@labregowski
Copy link

@PallasKatze , @exiva, @rvlaskamp, @lorenzocavina, mairh
Sorry for the almost spammy post.
I know this is a stupid question but I am sort of clueless. How do I build the instascan.min.js, after cloning the source? what is everyone using in this project? webpack?
Again, I know this is kind of a skewed question and certainly not an issue, but I am not finding a way and have been researching quite a lot trying to use npm's build-bundle, npm i, browserify, etc...
Could anyone show me the right track for me to follow?
thanks in advance.

@TheZoker
Copy link

TheZoker commented Feb 4, 2018

@nicolasjnm Have a look here:
#105
@PallasKatze Do you have any idea, why the rear camera on android is not working anymore?

@chrswk
Copy link

chrswk commented Feb 14, 2018

@schmich What is the status of this project? I love this library and it works great, but it needs a some love, some updates and a new release. 😊 I'm willing to throw money at this, if that is any incentive. I would hate to see this thing die...

@mairh
Copy link

mairh commented Feb 14, 2018

Perhaps invite more collaborators/members on this repo if maintaining it alone is too much hassle and time-consuming.

@jerodfritz
Copy link

Can this be merged

@ro-savage
Copy link

@PallasKatze - It has been almost 6 months with no response.

Myself and I am sure many others are maintaining forks of this repo to get iOS 11 work. Did you want to create a permanent fork and release under a new name on npm?

@PallasKatze
Copy link
Author

Did you want to create a permanent fork and release under a new name on npm?

@ro-savage Sounds good. Will do this later today.

@Legym
Copy link

Legym commented Mar 10, 2018

Really looking forward to this merge

@dowadidi
Copy link

I'm getting an error trying to run a build. I'm not sure what I'm doing wrong.
Can someone help me out and post a build of this version?

@cvisl
Copy link

cvisl commented Aug 23, 2018

Why hasn't this been merged yet? I have been struggling with the IOS and eventually got it working with @centogram 's fork, but I would like to use the official one eventually (no offence centogram, great work on the fix ;)).

@Ruffio
Copy link

Ruffio commented Aug 23, 2018

There havn't been any commits for more than a year and the RP and issues here at Github has been pilling up. To me it looks like @schmich has abandoned the project :-( Hopefully I'm wrong :-)

@joaoescribano
Copy link

Awesome Branch... this should be used as master branch...

  • Faster rendering
  • Faster loading
  • Smaller file
  • Faster QRCode decoding

Compiled instascan.min.js of this branch:

instascan.min.zip

@andymac4182
Copy link

Any movement on this?

@joaoescribano
Copy link

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.