-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 11, Webpack and moar #78
base: master
Are you sure you want to change the base?
Conversation
@PallasKatze Since you have added a bunch of fixes in this PR. I would suggest you add the fix for iOS11 compatibility and rear camera fix too as discussed in the issue. #54 |
@mairh Will do this once I get an iOS update and test the fix |
Sure. If you are feeling impatient and want to test it sooner you can sign up for iOS 11 beta program and install the latest version https://beta.apple.com/sp/betaprogram/ |
Seems like I fixed the issue in Mobile Safari 11. Can anyone test and confirm this? |
@PallasKatze I've tested it on iOS 11 safari (both iPhone and iPad) and it works nicely. One thing I would like to confirm if the back camera on mobile is inverted by default. Is it the intended behavior or should we have an option not to opt for the inverted camera option? |
@mairh Thanks
We already have |
But it makes more sense to have the mirror option (default: true) only for the front-facing camera. On mobile (since the default is the back-facing camera) the mirror option should be set to false. Can you make that change? I think it could either go as default in camera.js or app.js (custom). |
I'm not sure there is a simple way to determine whether the camera is front- or back-facing. Please open a new issue for you feature request. |
Seems like there is an issue for this already #70 |
@schmich any thoughts on this PR? |
why do i not work it sucessful |
Hi @PallasKatze, Thank you very much. |
IOS11 Safari crashes after scanning 10 qrcodes. It reloads the page and all results are missing. Are you guys having the same issues or maybe it's an issue with my setup. I'm using Vue.JS. I initialize the camera if my app is mounted and the starting and stopping the camera if a qrcode is scanned. This works fine in Chrome Browser on MacOS, but in Safari on IOS11 it crashes infrequently. |
@rvlaskamp I got a few crashes while testing this on iPhone 6. My assumptions: 1) It's a bug in Safari 11; 2) Safari runs out of memory and kills the tab. Anyway, we need to find a way to reduce memory consumption. Try increasing the |
Android fails out when trying to access the rear camera on this pull request with
with and without the webrtc-adapter. Front camera works fine. |
@exiva I get the same error. Were you able to find a solution? |
@jscadden No, I have not yet. |
Hi, I trying to select the rear camera on iOS and I still look the frontal camera. any ideas!? |
Were anyone able to find a solution? |
@PallasKatze , @exiva, @rvlaskamp, @lorenzocavina, mairh |
@nicolasjnm Have a look here: |
@schmich What is the status of this project? I love this library and it works great, but it needs a some love, some updates and a new release. 😊 I'm willing to throw money at this, if that is any incentive. I would hate to see this thing die... |
Perhaps invite more collaborators/members on this repo if maintaining it alone is too much hassle and time-consuming. |
Can this be merged |
@PallasKatze - It has been almost 6 months with no response. Myself and I am sure many others are maintaining forks of this repo to get iOS 11 work. Did you want to create a permanent fork and release under a new name on npm? |
@ro-savage Sounds good. Will do this later today. |
Really looking forward to this merge |
I'm getting an error trying to run a build. I'm not sure what I'm doing wrong. |
Why hasn't this been merged yet? I have been struggling with the IOS and eventually got it working with @centogram 's fork, but I would like to use the official one eventually (no offence centogram, great work on the fix ;)). |
There havn't been any commits for more than a year and the RP and issues here at Github has been pilling up. To me it looks like @schmich has abandoned the project :-( Hopefully I'm wrong :-) |
Awesome Branch... this should be used as master branch...
Compiled instascan.min.js of this branch: |
Any movement on this? |
Awesome! |
This PR incorporates some changes from already opened PRs and adds some more.
babel-polyfill
replaced withtransform runtime
webrtc-adapter
shim removed from dependencies since there is no need to use this shim in most modern browsers (tested in latest Chrome Desktop, latest Opera, latest Firefox, Safari 11 beta 6). Edge and Chrome for Android (sic!) still need this shim (added a note to README).node
)Ref. /pull/48
Ref. /pull/49
Ref. /pull/55
Ref. /pull/63
Closes /issues/42
Closes /issues/47
Closes /issues/54