Obs priors #365
Merged
Obs priors #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrometry up to 2018 to test obs priors
semaphoreP
approved these changes
Apr 11, 2024
|
Image is displaying for me in the tutorial, and the CI run through the notebooks passed. Not sure why you couldn't see it. I'm going to pull this in but we can fix it later if it's still not working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the observation-based priors (finally!)
I added a new basis to match the one derived in Kelly's original paper, and modified the code on my old branch to implement the math correctly. @clarissardoo and I also wrote up a tutorial, and I added some unit tests. I'm running a longer end-to-end fit (using the new tutorial, just running for a goodly number of steps), and I'll post the results from that here so we can visually compare to a published independent implementation.