Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kosmo O'Neil priors to priors.py #63

Closed
sblunt opened this issue Sep 19, 2018 · 6 comments
Closed

Add Kosmo O'Neil priors to priors.py #63

sblunt opened this issue Sep 19, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sblunt
Copy link
Owner

sblunt commented Sep 19, 2018

See https://arxiv.org/pdf/1809.05490.pdf, awesome work by K. Kosmo O'Neil. Would be great to have these priors as options in orbitize!

@sblunt sblunt added enhancement New feature or request help wanted Extra attention is needed labels Sep 19, 2018
@sblunt sblunt self-assigned this Jan 10, 2019
@isabelangelo isabelangelo self-assigned this Jan 29, 2019
@sblunt sblunt removed their assignment Mar 18, 2019
@sblunt sblunt assigned sblunt and unassigned isabelangelo Jul 10, 2019
@sblunt
Copy link
Owner Author

sblunt commented Aug 6, 2020

A first-draft version of this feature for MCMC only is implemented in the obs-priors branch. Summary of game plan for OFTI incorporation that came out of discussion with Greg Martinez & Kelly Kosmo today:

  • use rejection sampling to generate samples from the ObsPrior. Proposal distributions: log-uniform in P, uniform in e
  • rotate Omega but don't scale sma

@sblunt
Copy link
Owner Author

sblunt commented Sep 7, 2020

The Jacobian currently implemented on the obs-priors branch isn't correct, since we're using a sma basis, and the Jacobian in Kelly's paper involves partial derivatives assuming we fit in a per basis. I need to calculate and implement the correct Jacobian.

@sblunt sblunt added this to the v2.0 milestone Apr 21, 2021
@sblunt sblunt removed this from the v2.0 milestone Aug 26, 2021
@sblunt
Copy link
Owner Author

sblunt commented Sep 14, 2021

@isabelangelo I just merged the changes from main into my obs-priors branch, if you want to check out what I've coded up so far for this. As I understand it now, the remaining TODOs are:

  • derive the analytical form for the standard orbitize basis
  • update the code (potentially change the way I initially coded it to be consistent with the newer API)
  • test & document
  • (potentially): expand to other bases

Feel free to use the code I have as a starting point or to completely start over (I won't be offended either way).

@isabelangelo
Copy link
Collaborator

Thanks Sarah this is super helpful :) I'll look over it and see how much of the code we want to incorporate, but regardless it's good to have for reference!

@sblunt
Copy link
Owner Author

sblunt commented Mar 1, 2024

It's been 84 years, but finally this issue will be addressed in PR #365!

@sblunt
Copy link
Owner Author

sblunt commented Apr 11, 2024

Addressed!!!

@sblunt sblunt closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants