Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test @portabletext/editor with react compiler #7706

Closed
wants to merge 4 commits into from

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Oct 30, 2024

Just a test, to see the eFPS numbers. This isn't intended to be merged

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:45am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:45am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:45am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:45am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:45am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 10:45am

Copy link

socket-security bot commented Oct 30, 2024

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Component Testing Report Updated Oct 31, 2024 10:42 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 39s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 48s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 17s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 30, 2024

⚡️ Editor Performance Report

Updated Thu, 31 Oct 2024 10:44:34 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.1 efps (62ms) 17.2 efps (58ms) -4ms (-6.5%)
article (body) 53.5 efps (19ms) 61.5 efps (16ms) -2ms (-13.1%)
article (string inside object) 18.2 efps (55ms) 17.7 efps (57ms) +2ms (+2.7%)
article (string inside array) 15.2 efps (66ms) 14.1 efps (71ms) +5ms (+7.6%)
recipe (name) 27.8 efps (36ms) 27.4 efps (37ms) +1ms (+1.4%)
recipe (description) 30.3 efps (33ms) 30.8 efps (33ms) -1ms (-1.5%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (8ms) +2ms (-/-%)
synthetic (title) 14.3 efps (70ms) 14.5 efps (69ms) -1ms (-1.4%)
synthetic (string inside object) 14.7 efps (68ms) 15.2 efps (66ms) -2ms (-2.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 62ms 70ms 80ms 122ms 496ms 13.4s
article (body) 19ms 21ms 44ms 118ms 218ms 5.8s
article (string inside object) 55ms 60ms 68ms 292ms 455ms 8.8s
article (string inside array) 66ms 70ms 80ms 342ms 1102ms 9.7s
recipe (name) 36ms 40ms 60ms 96ms 0ms 9.3s
recipe (description) 33ms 34ms 38ms 69ms 12ms 6.3s
recipe (instructions) 6ms 8ms 9ms 24ms 0ms 3.3s
synthetic (title) 70ms 73ms 79ms 379ms 1527ms 15.8s
synthetic (string inside object) 68ms 72ms 80ms 473ms 1760ms 10.6s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 58ms 62ms 96ms 179ms 621ms 13.2s
article (body) 16ms 19ms 24ms 159ms 142ms 5.2s
article (string inside object) 57ms 63ms 71ms 134ms 489ms 8.8s
article (string inside array) 71ms 76ms 81ms 250ms 1259ms 10.4s
recipe (name) 37ms 39ms 63ms 95ms 3ms 9.4s
recipe (description) 33ms 35ms 39ms 100ms 19ms 6.3s
recipe (instructions) 8ms 9ms 10ms 16ms 0ms 3.4s
synthetic (title) 69ms 73ms 80ms 362ms 1642ms 15.5s
synthetic (string inside object) 66ms 69ms 86ms 506ms 1258ms 10.1s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant