Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use react-compiler to optimise render #319

Merged
merged 2 commits into from
Nov 1, 2024
Merged

feat: use react-compiler to optimise render #319

merged 2 commits into from
Nov 1, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Oct 30, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portable-text-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 10:28am

@socket-security Socket Security
Copy link

socket-security bot commented Oct 30, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment +3 7.73 MB react-bot
npm/[email protected] environment, filesystem, unsafe 0 7.7 MB prettier-bot
npm/[email protected] environment 0 24 kB react-bot
npm/[email protected] None 0 22.4 MB typescript-bot
npm/[email protected] None 0 667 kB colinmcd94

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@stipsan stipsan marked this pull request as ready for review October 30, 2024 19:39
@stipsan stipsan enabled auto-merge (squash) October 30, 2024 20:07
@christianhg
Copy link
Member

Is it perhaps a bit incorrect to use feat for this commit? As far as I can tell, the PR enables the compiler for the Playground and the tests. Or did I misunderstand something?:

@christianhg christianhg disabled auto-merge November 1, 2024 10:05
christianhg
christianhg requested changes Nov 1, 2024
View reviewed changes
Copy link
Member

@christianhg christianhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some doubts in the comments so marking this as "Request changes"

@christianhg
Copy link
Member

LFG

@stipsan stipsan merged commit 35b6c27 into main Nov 1, 2024
11 of 12 checks passed
@stipsan stipsan deleted the react-compiler branch November 1, 2024 10:27
@ecoscript ecoscript bot mentioned this pull request Nov 1, 2024
Merged
This was referenced Nov 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianhg christianhg christianhg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stipsan @christianhg