Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bubble related toggles from initial screen in TestingApp #1173

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Remove bubble related toggles from initial screen in TestingApp #1173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions GliaWidgets/Public/Glia/Glia.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@
var loggerPhase: LoggerPhase
var queuesMonitor: QueuesMonitor
var alertManager: AlertManager
// We need to store `features` via `configure` or deprecated `startEngagement` methods
// to use it when engagement gets restored for Direct ID authentication flow.
// We need to store `features` via `configure` method to use it
// when engagement gets restored for Direct ID authentication flow.
var features: Features?

private(set) var configuration: Configuration?
Expand Down Expand Up @@ -195,7 +195,7 @@
/// - `GliaError.configuringDuringEngagementIsNotAllowed`
/// - `ConfigurationError`
///
public func configure(

Check warning on line 198 in GliaWidgets/Public/Glia/Glia.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 11 (cyclomatic_complexity)

Check warning on line 198 in GliaWidgets/Public/Glia/Glia.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

Function Body Length Violation: Function body should span 60 lines or less excluding comments and whitespace: currently spans 75 lines (function_body_length)
with configuration: Configuration,
theme: Theme = Theme(),
uiConfig: RemoteConfiguration? = nil,
Expand Down
Loading
Loading