Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bubble related toggles from initial screen in TestingApp #1173

Conversation

EgorovEI
Copy link
Contributor

MOB-3907

What was solved?
This PR revert changes introduced in PR:

  • Removes bubble related controls from initial screen;
  • Updates comments/documentation for var features: Features? in Glia instance.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

Simulator Screenshot - iPhone 15 Pro - 2024-12-30 at 16 46 26

Copy link
Contributor

@ykyivskyi-gl ykyivskyi-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xib or storyboard in PR, it's been a long time 🙂

@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 01e024c to 7ad0d5b Compare December 31, 2024 10:38
- Remove bubble related controls from initial screen;
- Update comments/documentation for var features: Features? in Glia instance.

MOB-3907
@EgorovEI EgorovEI force-pushed the task/MOB-3907-remove-bubble-related-toggles branch from da3bcad to 989cc8b Compare December 31, 2024 10:39
@EgorovEI EgorovEI merged commit 25d2a27 into feature/entry-widget-and-secure-conversations-v2 Dec 31, 2024
8 checks passed
@EgorovEI EgorovEI deleted the task/MOB-3907-remove-bubble-related-toggles branch December 31, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants