feat: upgrade to promethues v3.0.0

[saidsef]

No description provided.

[saidsef]

/code pr

[saidsef]

🤖
Here's my review of the Prometheus upgrade changes:

File: deployment/prometheus/deployment.yml

Suggestions for enhancement:

# Add resource limits for better resource management
resources:
  limits:
    cpu: "1"
    memory: "2Gi"
  requests:
    cpu: "500m"
    memory: "1Gi"

Issues:

1. Line 28: Upgrading directly from v2.55.1 to v3.0.0 is a major version change that might require testing for breaking changes and data compatibility
2. Line 37-38: The new flags --no-auto-gomaxprocs and --no-auto-gomemlimit might affect performance tuning; suggest documenting the reasoning for disabling these automatic settings

The upgrade looks functional but would benefit from additional resource management and careful testing of the major version upgrade.

_{> claude-3-5-sonnet-20241022 [pr | 0]}

[saidsef]

/code pr

[saidsef]

🤖
I'll review the changes across these 4 patches:

Patch 1 - Prometheus v3.0.0 Upgrade:
✅ Good: Adds OTLP receiver and memory management flags
⚠️ Consider: Adding resource limits/requests for new v3.0.0 since it may have different resource needs

Patch 2 - Prometheus Feature Cleanup:
✅ Good: Removes unsupported features and simplifies HTTP duration recording rule
⚠️ Consider: The simplified recording rule may need additional labels for proper metric aggregation
🔧 Suggestion: Document the impact of removed features for maintenance

Patch 3 - Grafana Upgrade:
✅ Good: Minor version bump with security fixes
✅ Clean change with proper reference to release notes

Patch 4 - Documentation Update:
✅ Good: Adds Pyroscope to documentation
⚠️ Consider: Adding installation/setup instructions for Pyroscope since it's now mentioned

Overall comments:

• The changes are well-structured and logically grouped
• Prometheus v3 upgrade handles breaking changes appropriately
• Good practice linking to release notes
• Documentation updates match implementation changes

Would you like me to elaborate on any specific aspect?

_{> claude-3-5-sonnet-20241022 [pr | 2]}