Release v1.1.0 #1255

katspaugh · 2022-11-28T08:06:56Z

Features

[Epic] Safe Creation ([Epic] Safe Creation #988) (A/B test)
feat: Collapsable sidebar in Safe App view (feat: Collapsable sidebar in Safe App view #1169)
feat(safe-apps): Add support for receiving analytics from our Safe Apps (feat(safe-apps): Add support for receiving analytics from our Safe Apps #1066)
add: data management tab with import all data button (add: data management tab with import all data button #1103)

Improvements

feat: redesign address book import (feat: redesign address book import #1137)
refactor: simplify GTM logic + unmount on permission removal (refactor: simplify GTM logic + unmount on permission removal #1047)
Refactor: paginated NFT select (Refactor: paginated NFT select #1235)

Bug fixes

fix: Dislay an error when trying to transfer safe token (fix: Dislay an error when trying to transfer safe token #1250)
fix: Send current step with tracking event (fix: Send current step with tracking event #1249)
Fix: show upgrade notification only to owners (Fix: show upgrade notification only to owners #1070)
fix(safe-apps): Safe apps analysis improvements (fix(safe-apps): Safe apps analysis improvements #1136)
Fix: sandbox safe app icons (Fix: sandbox safe app icons #1193)
fix: show warning based on trusted flag (fix: show warning based on trusted flag #1226)
fix: flag Keystone wallets as hardware wallets + adjust modal z-index (fix: flag Keystone wallets as hardware wallets + adjust modal z-index #1194)
fix: redirect to /home of Safe present in URL (fix: redirect to /home of Safe present in URL #1183)
Fix: added safes across chains (Fix: added safes across chains #1167)
Fix: backdrop color (Fix: backdrop color #1186)
fix: handle invalid shortname in url (fix: handle invalid shortname in url #1160)
Fix: MUI Switch default color (Fix: MUI Switch default color #1189)
fix: pressing enter doesn't set max (fix: pressing enter doesn't set max #1168)
fix: checksum lowercase addresses + validate checksums (fix: checksum lowercase addresses + validate checksums #1127)

Docs & chores

Chore: PR deployment action (Chore: PR deployment action #1197)
add: docs for import all feature (add: docs for import all feature #1152)
fix: improve reliability of E2E tests (fix: improve reliability of E2E tests #1182)
improve reliability of create_tx cypress test (e2e: improve reliability of create_tx cypress test #1196)

* fix: use `intercept` callback in tx creation test * test: assert button + await `/safe-apps` * fix: move `timeout` to selector

* Fix: MUI Switch default color * Keep primary color in dark mode

* add: docs for import all feature * Rephrasing and additions Co-authored-by: Aaron Cook <[email protected]> * rephrase sentence Co-authored-by: Aaron Cook <[email protected]>

* fix: handle invalid shortname in url * fix: failing test * fix: Move logic into usePathRewrite and add error logging * fix: Add additional test for usePathRewrite * refactor: Change error code * refactor: Reuse useUrlChainId * fix: trackError instead of just logging

* Fix: backdrop color * Close new tx modal when a submodal is open

* Chore: PR deployment action * On pull * Fix syntax * Dev bucket * AWS_REVIEW_BUCKET_NAME * hr -> br * Change link title * Refactor: extract upload script

* feat: add `TagManager.destroy` function * refactor: GTM * fix: add dev log * Merge branch 'dev' into refactor-gtm * fix: extract constant * fix: remove all GTM scripts * fix: disable GTM/GA programmatically * fix: remove cookies * fix: adjust tests * fix: reload instead of using flag * fix: tests

* Added collapsable sidebar in Safe App view * show sidebar only in desktop resolution and added some hover animations * added extra timeout to EstimationRequest

…x` (#1194) * fix: flag Keystone wallets as hardware wallets * fix: adjust `z-index` of modals * fix: adjust `z-index` of onboard * fix: increase Keystone modal by `1` * fix: revert `z-index` * fix: increase `z-index` value

* fix: show warning based on flag * fix: flag * fix: revert wording * fix: flag * fix: update lock file

* updated sidebar to be opened by default * moved create_tx.cy.js test file out of the smoke folder

…ps (#1066)

* Fix: sandbox safe app icons * Fix tests * Srcdoc * Use SandboxedIcon for all app icons * Rename component * Fix: make the icon clickable

* feat: new creation design + step 1 * fix: widget width * refactor: combine components * fix: rename folder + remove CSS module * fix: missing padding * fix: Reuse NetworkSelector component * [Safe Creation] Owner step (#989) * feat: basic step 2 implementation Co-authored-by: iamacook <[email protected]> * feat: creation info widget (#960) * feat: creation info widget * fix: Remove demo page Co-authored-by: Usame Algan <[email protected]> * Safe creation stepper (#992) A new CardStepper component which controls the steps for new safe creation which can - go back and forth - jump to a specific step - set an initial step - set initial values - renders a progress bar - step data is stored in an object with a generic type - the update functions (onBack, onSubmit) use Partials of that type such that each step does not need to submit the full data change /demo route to /create-safe Co-authored-by: Usame Algan <[email protected]> * Review step redesign (#993) * feat: new create safe review step * calculate total gas fee * fill the form values * refactor review rows * fix: implement Figma designs * fix: background-color on network fee * avoid infinite rerendering * integrate review step in new Stepper * style: visual tweaks * fix: Create safe layout adjustments (#997) * fix: Create safe layout adjustments * fix: overview widget margin top * fix: Move overview widget to top on mobile * feat: AB testing system (#1013) * feat: AB testing system * fix: remove reset function + test `AbTest` value * Refactor: sync useLocalStorage across components and tabs (#977) * Refactor: external store in useLocalStorage * Comment * Sync separately * Use the storage event for syncing * Rm comment * Restore prev behavior wrt undefined * Simplify the undefined check * Allow undefined and rm initialValue * Don't set undefined * Local storage to return null when not found * Initial value * Rm initial value again * usePendingCreation * Rm redundant code * Refactor: external store in useLocalStorage (#1014) Refactor: external store in useLocalStorage * feat: create `useABTesting` hook for setting event * fix: reorganise structure Co-authored-by: katspaugh <[email protected]> * feat: add AB testing to Safe creation (#1017) * [Create Safe] feat: Connect wallet step (#1006) * fix: Add connect wallet step to safe creation * fix: Remove unused method * fix: Reuse components, adjust modal zIndex * fix: Only run onConnect callback if there was no error when connecting a wallet * fix: Set wallet owner in form on connect * fix: Check for connected wallet * style: Use onboard zindex variable * [Create Safe] add overview and CreateSafeInfo widget (#1002) * add overview and CreateSafeInfo widget - displays safe name and connected wallet during owner setup - displays hints for each step + dynamic hints during owner and threshold setup - state is pulled up into the CreateSafe component and update functions passed into the owner step * step static tips are collapsed by default * navigate tips logic * reverse expanded logic * restyle InfoWidget * remove the add mobile owner row * remove flickering when opening the accordion * fix keys * add hover style to the Accordion expand icon * Accordion summary bold when expanded * style: PR comments * fix empty form data name * simplify map key * link to Safe setup article * change allOwners logic * mv sx to css modules * add current chain in Overview widget Co-authored-by: Diogo Soares <[email protected]> * [Create Safe] feat: Status view redesign (#1018) * feat: Implement create safe status redesign * style: Add animated loading spinner * fix: Simplify conditions * add: animate into css safe logo * fix: use numeric enum for simpler conditions, adjust animated logo sizes * fix: Display dialog after safe creation * fix: Feedback * fix: Better name for query param Co-authored-by: schmanu <[email protected]> * [Safe creation] Creation links tooltips (#1061) * add link to tip * add missing tooltips * update copy * use SvgIcon to inherit viewBox * fix: inherit `fill` Co-authored-by: iamacook <[email protected]> * fix: textual inconsistencies + add hint (#1065) * [Safe Creation] Layout adjustments (#1063) * style: Safe Creation layout * fix: Align threshold text * [Create Safe] Handle wallet connection (#1087) * fix: Handle wallet connection when creating safe * fix: Only watch threshold * refactor: Rename useSetCreationStep to useSyncSafeCreationStep * fix: Use formState.isValid * fix: Add tests for useSyncSafeCreationStep * fix: Show error notifications in safe creation (#1135) * fix: Show error notifications in safe creation * fix: Add closeByGroupKey action to notification slice * fix: Safe creation issues (#1180) * fix: Navigate back to the welcome page on cancel * fix: Reuse NameInput for new form * fix: Use currentColor for icons * fix: check for pending safe creation in first step (#1190) * fix: reduce threshold when removing owner (#1181) * fix: reduce threshold when removing owner * fix: use enum for all field names * fix: reduce code * Safe creation text updates (#1198) * fix: Update text and layout for step 0 * fix: Update text for step 2 and 3, show copy and explorer icons for addresses * fix: Update text for status messages * fix: Update hint texts * fix: Update creation modal text, add dynamic values * fix: QR reader crashes app (#1200) * fix: Safe Creation color issues (#1204) * fix: Safe Creation color issues * chore: Add TODO * fix: Remove static colors and use palette directly * fix: Add overview widget to step 1 in safe creation (#1210) * fix: Add missing safe creation events (#1212) * fix: Add missing safe creation events * fix: Add new events for hints * fix: Watch safe creation tx even without a connected wallet (#1215) * fix: Watch safe creation tx even without a connected wallet * fix it in the old safe creation flow too * fix: failing test * fix: Add additional test * fix: Only watch safe creation tx once (#1223) * fix: Only watch safe creation tx once * fix: Detect if tx reverted when ethers throws error * refactor: Remove unused code that was duplicated (#1230) * refactor: Remove unused code that was duplicated * fix: Revert ab test removal * refactor: Remove unused StepCard component * fix: Update links to safe.global * fix: Set link to safe creation for ab testing * fix: Hide sidebar on safe creation * fix: Revert ab test change * fix: Center QR code reload icon * fix: Safe cration text changes (#1239) * fix: Safe cration text changes * fix: Adjust safe indexed message * fix: Adjust safe indexed message Co-authored-by: iamacook <[email protected]> Co-authored-by: Manuel Gellfart <[email protected]> Co-authored-by: Diogo Soares <[email protected]> Co-authored-by: katspaugh <[email protected]> Co-authored-by: Diogo Soares <[email protected]>

* Refactor: paginated NFT select * Collection name

* fix: Dislay an error when trying to transfer safe token * fix: feedback

github-actions · 2022-11-28T08:10:39Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2022-11-28T08:12:56Z

Branch preview

https://pr1255--webcore.review-react-br.5afe.dev

katspaugh · 2022-11-28T08:14:56Z

CloudFlare link: https://release-1-1-0.web-core.pages.dev/

JagoFigueroa · 2022-11-28T13:25:59Z

Hola team! I am having some trouble to see the analytic events for safe apps. No events are triggering for me on the apps available on the safe apps RC. A couple of examples:

Tx-builder:

analytics.mp4

WC:

analytics.2.mp4

Any idea what the issue might be?

Ninja edit: I can see GTM events when navigating the apps available on the RC branch, the issue seems to be specific to the safe app pr branches. Will link this message on our side as well.

Un abrazo

katspaugh · 2022-11-28T14:06:18Z

I've just tried on https://release-1-1-0.web-core.pages.dev/gor:0xc8b4dA63f0b4413E4C8815143d28a642F6BD2309/apps?appUrl=https%3A%2F%2Fpr584--safereactapps.review-react-hr.5afe.dev%2Ftx-builder%2F and it does send out GTM events:

Stupid question, did you accept all the cookies, @JagoFigueroa?

JagoFigueroa · 2022-11-28T15:03:25Z

You are right señor @katspaugh , I can see events as well. Was trying to trigger the newly implemented ones on our RC specifically to start with and as I could not see them thought it was a global issue 🤦

I will move this conversation to safe-apps as well to see if there might be something off with those new events in particular. Gracias!

Edit: the issue was that the PR urls where not whitelisted, that's why the new events are not triggering.

usame-algan

LGTM

francovenica · 2022-11-28T19:44:20Z

Question:
I'm checking the safe apps GA events in the console and it seems that the same event is called several times (it depends on the app). They all seem to be the same event, just triggered several times. Is this correct?
Tagging @yagopv since you worked on that ticket
Edit: They have a "uniqueEvent" that seems to be the only difference. Idk if that's is a counter that increases or there are actually events that have an unique ID (I assume is the former)

yagopv · 2022-11-28T20:32:08Z

It’s fine @francovenica, we are quantifying the method calls, in this case the RPC method eth_call but not the parameters used to call the method itself that will be the ones varying between calls.

This analytic is being sent each time the Safe Apps uses SDK for a method call so even if the app is doing some wrong things in any case is the code in web-core the cause.

francovenica · 2022-11-29T01:47:41Z

@JagoFigueroa @liliya-soroka can you check the #1136 and #1194 ?

francovenica · 2022-11-29T01:47:59Z

I've checked the rest of the tickets on the list and they are fine. Just reported an issue with Safe update notifications

Tomorrow I'll finish the regression checklist (signing with different wallets in different networs, AB, Spending limits, Tx lists, filters, send funds, etc...)

JagoFigueroa · 2022-11-29T08:34:16Z

#1136 looks mucho bueno to me.

A small issue is that the icon for copying to clipboard on the left menu does not have the proper styling on dark mode. I say we make it beautiful again for this release 💪

icon.mp4

JagoFigueroa · 2022-11-29T09:13:23Z

Anotha one! (Not 100% sure if it is an issue for this one, please correct me if it is an expected change)

Wallet connection modal on prod

Wallet connection modal on the RC

Edit: I can also see that the background color has changed as well:

JagoFigueroa · 2022-11-29T09:38:56Z

Sorry for the spam :pepe-scream:

There is a small issue (maybe inherited from the full screen mode for safe-apps?) on which now, the tx queue is shown in front of the transaction modal, making interaction a little bit tricky:

minimize.queue.mp4

RC vs Prod:

katspaugh · 2022-11-29T10:16:21Z

Regarding the wallet connection modal – I've noticed this too, probably an unintended change but it looks better IMHO. So I would keep it. @liliiaorlenko wdyt?

The new backdrop background color is correct.

@DaniSomoza could you take the Tx Queue overlap issue?

* Fix: copy button in dark mode * currentColor

francovenica · 2022-11-30T03:04:41Z

I didn't found other issues than the ones reported in the comments of this ticket. once those are fixed we can deploy

* fixed MUI theme zIndex for modals to avoid overlaps * restored the z-Index to the previous value ( z-index: 1) in the transaction Queue * adjusted Tx queue bar z-index to 1200 to make sure that looks good with the sidebar

iamacook and others added 24 commits November 17, 2022 14:54

fix: improve reliability of E2E tests (#1182)

faaf743

* fix: use `intercept` callback in tx creation test * test: assert button + await `/safe-apps` * fix: move `timeout` to selector

Fix: MUI Switch default color (#1189)

219a813

* Fix: MUI Switch default color * Keep primary color in dark mode

add: docs for import all feature (#1152)

f95d7be

* add: docs for import all feature * Rephrasing and additions Co-authored-by: Aaron Cook <[email protected]> * rephrase sentence Co-authored-by: Aaron Cook <[email protected]>

feat: redesign address book import (#1137)

e3556a2

Fix: backdrop color (#1186)

d5cea5d

* Fix: backdrop color * Close new tx modal when a submodal is open

Fix: added safes across chains (#1167)

5e70da0

Chore: PR deployment action (#1197)

35f8d34

* Chore: PR deployment action * On pull * Fix syntax * Dev bucket * AWS_REVIEW_BUCKET_NAME * hr -> br * Change link title * Refactor: extract upload script

improve reliability of create_tx cypress test (#1196)

19b5e8f

fix: redirect to /home of Safe present in URL (#1183)

03882c5

feat: Collapsable sidebar in Safe App view (#1169)

35a9526

* Added collapsable sidebar in Safe App view * show sidebar only in desktop resolution and added some hover animations * added extra timeout to EstimationRequest

fix: show warning based on trusted flag (#1226)

343edd4

* fix: show warning based on flag * fix: flag * fix: revert wording * fix: flag * fix: update lock file

Chore: updated sidebar to open by default (#1228)

9c07ab8

* updated sidebar to be opened by default * moved create_tx.cy.js test file out of the smoke folder

feat(safe-apps): Add support for receiving analytics from our Safe Ap…

0179201

…ps (#1066)

Fix: sandbox safe app icons (#1193)

36f3714

* Fix: sandbox safe app icons * Fix tests * Srcdoc * Use SandboxedIcon for all app icons * Rename component * Fix: make the icon clickable

fix(safe-apps): Safe apps analysis improvements (#1136)

eac0216

Fix: show upgrade notification only to owners (#1070)

d422941

Refactor: paginated NFT select (#1235)

6ffc44e

* Refactor: paginated NFT select * Collection name

fix: Send current step with tracking event (#1249)

243ad59

fix: Dislay an error when trying to transfer safe token (#1250)

6eb0acb

* fix: Dislay an error when trying to transfer safe token * fix: feedback

1.1.0

bd23d3a

katspaugh requested a review from usame-algan November 28, 2022 08:06

JagoFigueroa mentioned this pull request Nov 28, 2022

chore: new release safe-global/safe-react-apps#584

Merged

usame-algan approved these changes Nov 28, 2022

View reviewed changes

upgrade core-sdk (#1232)

e12783d

katspaugh requested review from francovenica and iamacook November 28, 2022 15:54

Fix: comment out the untrusted badge (#1262)

fd9468a

iamacook approved these changes Nov 28, 2022

View reviewed changes

katspaugh mentioned this pull request Nov 29, 2022

Fix: copy button in dark mode #1268

Merged

Fix: copy button in dark mode (#1268)

e980173

* Fix: copy button in dark mode * currentColor

fix: updated tx queue bar zIndex to avoid overlaps (#1276)

51e0792

* fixed MUI theme zIndex for modals to avoid overlaps * restored the z-Index to the previous value ( z-index: 1) in the transaction Queue * adjusted Tx queue bar z-index to 1200 to make sure that looks good with the sidebar

katspaugh merged commit 51e0792 into main Nov 30, 2022

katspaugh deleted the release/1.1.0 branch November 30, 2022 05:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v1.1.0 #1255

Release v1.1.0 #1255

katspaugh commented Nov 28, 2022

github-actions bot commented Nov 28, 2022 •

edited

Loading

github-actions bot commented Nov 28, 2022

katspaugh commented Nov 28, 2022

JagoFigueroa commented Nov 28, 2022 •

edited

Loading

katspaugh commented Nov 28, 2022

JagoFigueroa commented Nov 28, 2022 •

edited

Loading

usame-algan left a comment

francovenica commented Nov 28, 2022 •

edited

Loading

yagopv commented Nov 28, 2022 •

edited

Loading

francovenica commented Nov 29, 2022

francovenica commented Nov 29, 2022

JagoFigueroa commented Nov 29, 2022

JagoFigueroa commented Nov 29, 2022 •

edited

Loading

JagoFigueroa commented Nov 29, 2022

katspaugh commented Nov 29, 2022 •

edited

Loading

francovenica commented Nov 30, 2022

Release v1.1.0 #1255

Release v1.1.0 #1255

Conversation

katspaugh commented Nov 28, 2022

Features

Improvements

Bug fixes

Docs & chores

github-actions bot commented Nov 28, 2022 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Nov 28, 2022

Branch preview

katspaugh commented Nov 28, 2022

JagoFigueroa commented Nov 28, 2022 • edited Loading

katspaugh commented Nov 28, 2022

JagoFigueroa commented Nov 28, 2022 • edited Loading

usame-algan left a comment

Choose a reason for hiding this comment

francovenica commented Nov 28, 2022 • edited Loading

yagopv commented Nov 28, 2022 • edited Loading

francovenica commented Nov 29, 2022

francovenica commented Nov 29, 2022

JagoFigueroa commented Nov 29, 2022

JagoFigueroa commented Nov 29, 2022 • edited Loading

JagoFigueroa commented Nov 29, 2022

katspaugh commented Nov 29, 2022 • edited Loading

francovenica commented Nov 30, 2022

github-actions bot commented Nov 28, 2022 •

edited

Loading

JagoFigueroa commented Nov 28, 2022 •

edited

Loading

JagoFigueroa commented Nov 28, 2022 •

edited

Loading

francovenica commented Nov 28, 2022 •

edited

Loading

yagopv commented Nov 28, 2022 •

edited

Loading

JagoFigueroa commented Nov 29, 2022 •

edited

Loading

katspaugh commented Nov 29, 2022 •

edited

Loading