feat: signer account page to enable MFA, deviceFactor recovery on login #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmanu
changed the title
Branch preview❌ Deploy failed! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
iamacook
reviewed
Sep 27, 2023
usame-algan
reviewed
Sep 29, 2023
iamacook
reviewed
Oct 4, 2023
schmanu
commented
Oct 4, 2023
iamacook
reviewed
Oct 4, 2023
Comment on lines
29
to
32
| confirmPassword: '', | ||
| oldPassword: undefined, | ||
| newPassword: '', | ||
| storeDeviceShare: isDeviceShareStored, |
There was a problem hiding this comment.
Suggested change
| confirmPassword: '', | |
| oldPassword: undefined, | |
| newPassword: '', | |
| storeDeviceShare: isDeviceShareStored, | |
| [PasswordFieldNames.confirmPassword]: '', | |
| [PasswordFieldNames.oldPassword]: undefined, | |
| [PasswordFieldNames.newPassword]: '', | |
| [PasswordFieldNames.storeDeviceShare]: isDeviceShareStored, |
| if (!mpcCoreKit) { | ||
| return false | ||
| } | ||
| const { shareDescriptions } = mpcCoreKit?.getKeyDetails() |
There was a problem hiding this comment.
Suggested change
| const { shareDescriptions } = mpcCoreKit?.getKeyDetails() | |
| const { shareDescriptions } = mpcCoreKit.getKeyDetails() |
| return false | ||
| } | ||
| const { shareDescriptions } = mpcCoreKit?.getKeyDetails() | ||
| return !Object.entries(shareDescriptions).some((value) => value[0]?.includes('hashedShare')) |
There was a problem hiding this comment.
Suggested change
| return !Object.entries(shareDescriptions).some((value) => value[0]?.includes('hashedShare')) | |
| return !Object.values(shareDescriptions).some((value) => value[0]?.includes('hashedShare')) |
iamacook
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2455
How to test it
Checklist
Screenshots