Epic Seedless-onboarding #2534
Merged
Epic Seedless-onboarding #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://web3authcoresdk--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
* test: mpc wallet session rehydration, chain switching, onboard connection
iamacook
reviewed
Sep 27, 2023
| tickerName: chain.nativeCurrency.name, | ||
| } | ||
|
|
||
| const currentInstance = getStore() |
There was a problem hiding this comment.
getStore is not reactive. We should access useStore instead.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Co-authored-by: Usame Algan <[email protected]>
* feat: Implement account center redesign * fix: Continue as button spacing * fix: Failing e2e tests * refactor: useConnectWallet hook, explicit onLogin handling * fix: Failing test * fix: Show social login in overview header * fix: Move import data e2e test to global preference page
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1105 tests passing in 155 suites. Report generated by 🧪jest coverage report action from 73c5c73 |
* fix: Add social login feature toggle from config service * fix: Failing tests * fix: Address comments
* feat: Implement new form layout * fix: Add password strength check, add cancel button * fix: Use RHF isSubmitting flag, move validate logic into onChange * fix: Update form dynamically when connecting/disconnecting, show notifications on success/error * fix: Update password match when typing in a new password * fix: Allow medium and strong passwords * fix: reset form state, fix accordion expand * fix: simplify validation, extract regex logic and test * refactor: Extract isSocialLoginWallet * fix: Failing test * fix: Remove ts-ignore * fix: Dont reset form fields on error
ESLint Summary View Full Report
Report generated by eslint-plus-action |
* feat: Add password recovery modal design * fix: Close modal on login * fix: Extend disabled state, add progress bar * fix: Close connection popover when password recovery opens * fix: Move logic from useEffect into login handler * refactor: Reuse PasswordInput
* fix: Hide Security&Login from settings if not a social signer * refactor: Remove Boolean expression * fix: Add tooltip to info text on welcome page * fix: Close popover when password recovery opens * fix: Failing tests
* refactor: environment config for social wallet * refactor: Use IS_PRODUCTION directly, adjust isSocialWalletOptions * fix: Failing tests * fix: Adjust error message --------- Co-authored-by: Usame Algan <[email protected]>
* Fix: hide Social Login wallet button from onboard * Watch onboard modal * Move to useSocialWallet
katspaugh
reviewed
Nov 3, 2023
katspaugh
reviewed
Nov 3, 2023
usame-algan
force-pushed
the
web3authcoresdk
branch
from
88a2ac5 to
f22a797
Compare
katspaugh
previously approved these changes
Nov 3, 2023
* fix: Adjust connection center design * refactor: Use currentColor for the icon
Side effect: The redirect URI is changed from /serviceworker/redirect to /redirect
* fix: Add feature flag for social login * fix: Show simple Connect button in case feature is disabled * fix: Remove redirects on the welcome page
usame-algan
previously approved these changes
Nov 8, 2023
* chore: update mpc-core-kit * feat: set constant hashedFactorNonce
usame-algan
approved these changes
Nov 8, 2023
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Implements seedless onboarding via MPC Core SDK
Resolves #2452
How to test
Screenshots
Checklist