Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom cache page #2311

Merged
merged 12 commits into from
Nov 20, 2024
+345 −48
Merged

Custom cache page #2311

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3c10766
Add cache logic
moisses89 Oct 29, 2024
6199cbc
Fix tests
moisses89 Nov 5, 2024
71945a8
Refactor to a cache class
moisses89 Nov 11, 2024
848adae
Add tests for cache.
moisses89 Nov 11, 2024
c1a83e6
Add option to disable cache
moisses89 Nov 11, 2024
a7cab42
Revert removed comment
moisses89 Nov 11, 2024
db70a0d
Fix doc
moisses89 Nov 11, 2024
a73a466
Add review suggestions
moisses89 Nov 18, 2024
59ca164
Enable cache for testing
moisses89 Nov 18, 2024
a88801e
Merge branch 'main' into custom_cache_page
moisses89 Nov 18, 2024
91e92ad
Add optional parameter key
moisses89 Nov 19, 2024
856e499
Update safe_transaction_service/history/cache.py
moisses89 Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions safe_transaction_service/history/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ def remove_cache(self):


def cache_txs_view_for_address(
cache_tag: str, timeout: int = settings.CACHE_VIEW_DEFAULT_TIMEOUT
cache_tag: str,
parameter_key: Optional["str"] = "address",
moisses89 marked this conversation as resolved.
Show resolved Hide resolved
timeout: int = settings.CACHE_VIEW_DEFAULT_TIMEOUT,
):
"""
Custom cache decorator that caches the view response.
Expand All @@ -115,7 +117,7 @@ def _wrapped_view(request, *args, **kwargs):
query_params = sorted(request.request.GET.dict().items())
cache_path = urlencode(query_params)
# Calculate cache_name
address = request.kwargs.get("address")
address = request.kwargs.get(parameter_key)
cache_txs_view: Optional[CacheSafeTxsView] = None
if address:
cache_txs_view = CacheSafeTxsView(cache_tag, address)
Expand Down