Custom cache page #2311
Merged
Custom cache page #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
force-pushed
the
custom_cache_page
branch
from
b7869ce to
5cffb2c
Compare
moisses89
force-pushed
the
custom_cache_page
branch
2 times, most recently
from
d96c7f9 to
6199cbc
Compare
Uxio0
requested changes
Nov 14, 2024
| query_params = request.request.GET.dict() | ||
| cache_path = f"{urlencode(query_params)}" | ||
| # Calculate cache_name | ||
| address = request.kwargs["address"] |
There was a problem hiding this comment.
Maybe "address" should be an optional parameter to the decorator, so we can use different keys in the future
Also this can throw an exception if address does not exist. It should be: request.kwargs.get("address") so you can emit a warning when you evaluate if address: later
There was a problem hiding this comment.
My idea here is to start by the cases where a Safe is a part of the URL path.
Later if we are happy with the results we can move forward to other endpoints. What do you think?
There was a problem hiding this comment.
Either way, making address as a url path value configurable is just adding an optional parameter (by default 'address') to the decorator, something like caching_value_name
Uxio0
requested changes
Nov 19, 2024
Co-authored-by: Uxío <[email protected]>
Uxio0
approved these changes
Nov 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2008