Save more to database, forego the spotify library wherever possible. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… golang standards
Everything is now in layers such that there is a clear data path BREAKING CHANGE:
albe2669
added
enhancement
There was a problem hiding this comment.
Copilot reviewed 110 out of 124 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- api/ent.graphql: Language not supported
- api/playerState.graphql: Language not supported
- ent/ent.go: Evaluated as low risk
- cmd/main.go: Evaluated as low risk
- ent/gql_node.go: Evaluated as low risk
- ent/hook/hook.go: Evaluated as low risk
- ent/gql_edge.go: Evaluated as low risk
- ent/entc.go: Evaluated as low risk
- ent/album_delete.go: Evaluated as low risk
- ent/image.go: Evaluated as low risk
- ent/album/album.go: Evaluated as low risk
- ent/image/where.go: Evaluated as low risk
- ent/image_delete.go: Evaluated as low risk
- ent/artist.go: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To whoever has to review this: I'm sorry.........
Codebase Restructuring:
I've restructured most of the codebase to better fit with Go community standards, specifically:
*.graphqltoapi/frontend/toweb/lib/tointernal/internal/internal/Service Initialization:
Created services:
services/spotify.goto handle calling the spotify libraryservices/database.goto handle calling the databaseservices/shared.goto combine the previous two and serve as the service used throughout the codebaseservices/watcher.gosimplifies the code previously used for the player state loop into one place. This also removes a bunch of global variables :)New Models:
Created
album,artistandimagemodel that precisely mimic a subset of the Spotify web API. These serve as the internal representation and shall be used in place of the Spotify library.trackhas also been modified extensively to uphold the same properties as the others.Model binding
model_binding.goserves as the file where external data types meet ours.closes #7 #45 #46