Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type fixing #39

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Type fixing #39

merged 2 commits into from
Nov 12, 2024

Conversation

albe2669
Copy link
Collaborator

Typefixing

@albe2669 albe2669 added bug Something isn't working dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 12, 2024
@albe2669 albe2669 self-assigned this Nov 12, 2024
@albe2669 albe2669 marked this pull request as ready for review November 12, 2024 18:38
@albe2669 albe2669 requested a review from Slug-Boi November 12, 2024 18:40
@Slug-Boi Slug-Boi merged commit 64dcd87 into master Nov 12, 2024
1 check passed
@Slug-Boi Slug-Boi deleted the type-fixing branch November 12, 2024 18:40
@albe2669 albe2669 requested a review from Copilot November 20, 2024 07:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • graph/spotifyLib.graphql: Language not supported
  • frontend/src/components/AlbumCover.vue: Evaluated as low risk
  • frontend/src/components/Controls.vue: Evaluated as low risk
Comments skipped due to low confidence (3)

frontend/src/components/TrackInfo.vue:22

  • Removing optional chaining might cause runtime errors if trackObj.value.artists or its properties are null or undefined. Consider keeping the optional chaining to avoid potential issues.
return trackObj.value.artists.map((artist) => {

frontend/src/components/ProgressBar.vue:23

  • The removal of the fallback value for progressObj.value.timestamp could lead to runtime errors if progressObj.value.timestamp is undefined.
const timeAgo = computed(() => timestamp.value - (progressObj.value.timestamp));

frontend/src/components/ProgressBar.vue:24

  • The removal of the fallback value for progressObj.value.progress_ms could lead to runtime errors if progressObj.value.progress_ms is undefined.
const progressMs = computed(() => progressObj.value.progress_ms);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants