WIP: Use global system table pointer #905
Conversation
nicholasbishop
force-pushed
the
bishop-global-tables-2
branch
2 times, most recently
from
d532979
to
182bec4
Compare
nicholasbishop
force-pushed
the
bishop-global-tables-2
branch
from
182bec4
to
adf3c90
Compare
nicholasbishop
force-pushed
the
bishop-global-tables-2
branch
from
adf3c90
to
1de3d6a
Compare
nicholasbishop
force-pushed
the
bishop-global-tables-2
branch
6 times, most recently
from
b30c0b8
to
e9c03c1
Compare
nicholasbishop
force-pushed
the
bishop-global-tables-2
branch
2 times, most recently
from
a4b4e22
to
c4fc968
Compare
|
I'm wondering what's the right way forward here.
|
uefi/src/system.rs
Outdated
|
|
||
| /// TODO | ||
| pub unsafe fn set_system_table(system_table: *mut uefi_raw::table::system::SystemTable) { | ||
| SYSTEM_TABLE.store(system_table, Ordering::Release); |
There was a problem hiding this comment.
nit: This should use a Once-like type in the background. It should not be possible to set this multiple times.
I think something like AtomicOnce<uefi_raw::table::system::SystemTable> would be cool. Same for image handle.
uefi/src/system.rs
Outdated
| /// Return the firmware vendor string | ||
| #[must_use] | ||
| pub fn firmware_vendor() -> &'static CStr16 { | ||
| unsafe { CStr16::from_ptr(system_table().as_mut().firmware_vendor.cast()) } |
There was a problem hiding this comment.
Why did you decide to use functions here and not a new type having associated functions/methods?
There was a problem hiding this comment.
I left some notes here: #893 (comment)
Since there's no longer any struct or lifetime involved, I think these functions are similar to https://doc.rust-lang.org/std/env/#functions; no point attaching them to an empty struct.
|
Once I find a spare bit of time I'll re-familiarize myself with the content of this PR, make some updates, and remove the draft marker. |
nicholasbishop
force-pushed
the
bishop-global-tables-2
branch
2 times, most recently
from
515a508
to
19db510
Compare
|
I realized I was probably trying to do too much in one PR, so I've opened a simpler one to start things off: #1156 |
nicholasbishop
force-pushed
the
bishop-global-tables-2
branch
from
19db510
to
4589fd0
Compare
nicholasbishop
force-pushed
the
bishop-global-tables-2
branch
from
4589fd0
to
5006182
Compare
This will allow some code to be shared with the upcoming `uefi::boot` module.
The initial version here just provides functions for getting and setting the system time. Later commits will add functions to get/set variables, handle update capsules, etc. Also added some tests for the new code in the test runner (note that there were no existing tests for the time-related functions of `RuntimeServices`).
nicholasbishop
force-pushed
the
bishop-global-tables-2
branch
from
5006182
to
0f33a5c
Compare
nicholasbishop
force-pushed
the
bishop-global-tables-2
branch
from
0f33a5c
to
6b67b86
Compare
nicholasbishop
changed the title
|
Is there any reason to keep this MR open, @nicholasbishop ? |
|
Nope, at this point it has served its purpose. |
For #893
Checklist