Add basic API for a global system table #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nicholasbishop
force-pushed
the
bishop-global-tables-simple
branch
from
4ae0cd6
to
1dce0ad
Compare
phip1611
reviewed
May 3, 2024
phip1611
reviewed
May 3, 2024
phip1611
reviewed
May 3, 2024
nicholasbishop
force-pushed
the
bishop-global-tables-simple
branch
from
1dce0ad
to
8b47a44
Compare
nicholasbishop
force-pushed
the
bishop-global-tables-simple
branch
from
8b47a44
to
153aea5
Compare
This is a minimal solution to providing a global system table so that users of the API don't have to pass around references to `SystemTable` / `BootServices` / `RuntimeServices` everywhere.
This method was already unsafe in practice, since it's very hard to statically ensure that no references to boot-services data exist. Change the signature to acknowledge that reality, and update the docstring with details.
nicholasbishop
force-pushed
the
bishop-global-tables-simple
branch
from
153aea5
to
c04e423
Compare
|
Sorry for not giving the final review sooner. |
phip1611
reviewed
May 23, 2024
| // SAFETY: the system table is valid per the requirements of `set_system_table`. | ||
| unsafe { | ||
| if (*st).runtime_services.is_null() { | ||
| panic!("runtime services are not active"); |
There was a problem hiding this comment.
strictly speaking, they are also active, but not exclusively, right?
phip1611
approved these changes
May 23, 2024
|
As this is the begin of a larger refactoring: Would it make sense to make a plan on what is actually needed - or what the vision is? Do we want to track things in a ..milestone, github project board or so? @nicholasbishop |
|
Writing up more of a plan is a good idea, I will add it to #893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much simpler version than #905. Just the bare minimum: add functions to set and get the global system table, set the global system table in the
entrymacro, and also makeexit_boot_servicesunsafe.(I would still like to go in the direction of #905, but I think we should move a little incrementally so that we have a better chance of catching mistakes along the way.)
#893
Checklist