-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CI from bors to merge queue #13587
Conversation
295ed0b
to
c7ec86e
Compare
Not sure if I understand the CI error: https://github.com/rust-lang/rust-clippy/actions/runs/11513171989/job/32049393605#step:6:39. Does it actually check that the link returns 200? In that case, we'll need to update the badge only after merging this. |
Yes, it checks that all links in our markdown files actually lead to something (this check is actually copied from the Rust repo, so that we don't run into problems during sync). |
63790ff
to
3338611
Compare
Ok, I removed the badge URL changes, we can fix them up after this is merged. |
CI failure looks spurious. |
I restarted the run. It was spurious. |
It would cause issues with the required jobs, and it is probably useless anyway, the vast majority of PRs seem to change Rust source files.
867f897
to
843ef1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We decided to remove the path filters for PRs and run every workflow on every PR: clippy test and clippy dev test ran anyway on almost all PRs and Remark is really quick to run. This way it is possible to require PR CI to be green, before the PR is put into the merge queue. The reviewer still doesn't have to wait for the PR to be green, but can press "merge when ready" before that.
Context: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Reducing.20the.20amount.20of.20repos.20that.20use.20bors.2Fhomu
This should be merged with cooperation from an infra-admin.
Opening as a draft, because the CI on this repo is.. interesting :) So I want to make sure that the changes make sense. I renamed
clippy_bors.yml
toclippy.yml
andclippy.yml
toclippy_pr.yml
, which makes the diff a bit.. tricky.changelog: Move Clippy from bors to merge queues