Edition 2024

[samueltardieu]

This PR enables testing with Rust 2024 in the CI. It requires other PRs to be merged first, so I'll let it as a draft until this is done:

• Do not use gen as a variable name #13628
• Return iterator must not capture lifetimes in Rust 2024 #13629
• Use match ergonomics compatible with editions 2021 and 2024 #13630
• no_mangle attribute requires unsafe in Rust 2024 #13631

changelog: none

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[flip1995]

Not sure, if adding CI for this makes sense. The planned nightly release of the new edition is planned for in about 3-4 weeks. Then we might as well just move Clippy completely (assuming the linked PRs are merged.

But feel free to keep this PR open, if you just want to test/show on CI that everything is ready.

[samueltardieu]

Yes, this was the idea, to keep it open and rebase it from time to time after those PRs are merged, so that we get a feeling of how ready we are.

[Jarcho]

r? ghost

Since this isn't intended to be merged.

[rustbot]

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[Jarcho]

r? @ghost

[rustbot]

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

[bors]

☔ The latest upstream changes (presumably #13587) made this pull request unmergeable. Please resolve the merge conflicts.

[flip1995]

Looks like we are ready for edition 2024? 👀

[samueltardieu]

Looks like we are ready for edition 2024? 👀

Yes, all Clippy code in master compile without warning from the compiler or from Clippy itself. Nothing will have to be done, but selecting edition 2024 in Cargo.toml files.

[samueltardieu]

Closing because of #13751