Take result attributes directly from the production when resolving contexts #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgil-serbanuta
force-pushed
the
issue-4683
branch
3 times, most recently
from
87060c5 to
2b42de4
Compare
virgil-serbanuta
requested review from
ehildenb,
rv-jenkins,
F-WRunTime and
tothtamas28
as code owners
virgil-serbanuta
force-pushed
the
issue-4683
branch
from
2b42de4 to
a1c0ffa
Compare
tothtamas28
approved these changes
Nov 27, 2024
| @@ -119,6 +119,14 @@ private void setAliases(String attribute, Set<ContextAlias> aliases, Production | |||
| private static final ContextAlias DEFAULT_ALIAS = | |||
| ContextAlias(KVariable("HERE"), BooleanUtils.TRUE, Att.empty()); | |||
|
|
|||
| private static final ContextAlias defaultAliasWithAtts(Att att) { | |||
| if (!att.contains(Att.RESULT())) { | |||
| return DEFAULT_ALIAS; | |||
There was a problem hiding this comment.
If DEFAULT_ALIAS is not referred to elsewhere, consider inlining it here.
k-frontend/src/main/java/org/kframework/compile/ResolveStrict.java
Outdated
Show resolved
Hide resolved
Comment on lines
17
to
18
|
|
||
|
|
There was a problem hiding this comment.
Nitpick: consider removing these blank lines.
I hope it looks reasonable now. |
virgil-serbanuta
force-pushed
the
issue-4683
branch
from
d08b4c3 to
20b7730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A declaration like
syntax KItem ::= thing(Stuff, Stuff) [seqstrict, result(Evaluated)]should consider tems that are
Evaluatedas evaluated. Right now, this happens only for the argument being heated/cooled, while the previous arguments are checked for beingKResult. As an example, when heating the second argument above, the heating rule looks something like this:With this PR, the rule becomes
Fixes #4683