Fetch review comments

runtimeverification · Nov 27, 2024 · d08b4c3 · d08b4c3
1 parent 685c9b1
commit d08b4c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/k-distribution/tests/regression-new/issue-4683/test.k b/k-distribution/tests/regression-new/issue-4683/test.k
@@ -14,6 +14,4 @@ module TEST
   syntax Bool ::= isMyResult(K)  [function, total, symbol(isMyResult)]
   rule isMyResult(_) => false  [owise]
   rule isMyResult(c) => true
-
-
 endmodule
diff --git a/k-frontend/src/main/java/org/kframework/compile/ResolveStrict.java b/k-frontend/src/main/java/org/kframework/compile/ResolveStrict.java
@@ -116,12 +116,9 @@ private void setAliases(String attribute, Set<ContextAlias> aliases, Production
     }
   }
 
-  private static final ContextAlias DEFAULT_ALIAS =
-      ContextAlias(KVariable("HERE"), BooleanUtils.TRUE, Att.empty());
-
   private static final ContextAlias defaultAliasFor(Production production) {
     if (!att.contains(Att.RESULT())) {
-      return DEFAULT_ALIAS;
+      return ContextAlias(KVariable("HERE"), BooleanUtils.TRUE, Att.empty());
     }
     return ContextAlias(
         KVariable("HERE"), BooleanUtils.TRUE, Att.empty().add(Att.RESULT(), att.get(Att.RESULT())));
@@ -210,14 +207,14 @@ public Set<Sentence> resolve(Production production, boolean sequential) {
       for (int i = 1; i <= arity; i++) {
         strictnessPositions.add(i);
       }
-      aliases.add(defaultAliasWithAtts(production.att()));
+      aliases.add(defaultAliasFor(production.att()));
       resolve(sequential, sentences, arity, strictnessPositions, allPositions, aliases, production);
       allPositions.addAll(strictnessPositions);
     } else {
       String[] components = attribute.split(";");
       if (components.length == 1) {
         if (Character.isDigit(components[0].trim().charAt(0))) {
-          aliases.add(defaultAliasWithAtts(production.att()));
+          aliases.add(defaultAliasFor(production.att()));
           setPositions(components[0].trim(), strictnessPositions, arity, production);
         } else {
           for (int i = 1; i <= arity; i++) {