mark Int2Bytes(Int,Endianness,Signedness) rules as preserving definedness #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ness (/Int on RHS)
jberthold
force-pushed
the
HOTFIX-add-definedness-annotation-to-Int2Byte-conversions
branch
from
cc2b63f to
84df943
Compare
…ness-annotation-to-Int2Byte-conversions
geo2a
approved these changes
Jul 16, 2024
rv-jenkins
deleted the
HOTFIX-add-definedness-annotation-to-Int2Byte-conversions
branch
rv-jenkins
pushed a commit
that referenced
this pull request
Jul 23, 2024
…for booster (#4533) The previous change #4522 was insufficient to make the equations usable in `booster`. Matches with literal `Int` constants will still be indeterminate, so this PR removes the literals from the rule LHSs. * Use `0 ==Int I` instead of a syntactic _match_ in the equation for argument `0`. This enables evaluating terms with `I ==Int 0` in the path condition. * Remove equation with literal `-1` and widen requires in equation for negative arguments (previously `I <Int -1`, now `I <Int 0`). The result is the same as before with no extra equation required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the annotation,
boosterwon't use these rules.The
/Intdivision is partial but harmless in these rules.