Further fine-tune Int2Bytes(Int, Endianness, Signedness) equations for booster
#4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `0 ==Int I` instead of a syntactic _match_ of the argument with `0`. This enables evaluating terms with `I ==Int 0` in the path condition. * Remove case with literal `-1` and widen requires in equation for negative arguments (previously `I <Int -1`, now `I <Int 0`).
jberthold
force-pushed
the
HOTFIX-Int2Bytes-refactoring-no-2
branch
from
00c8afa to
6225293
Compare
|
NB Another, independent, issue is that the function is marked |
Baltoli
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous change #4522 was insufficient to make the equations usable in
booster. Matches with literalIntconstants will still be indeterminate, so this PR removes the literals from the rule LHSs.0 ==Int Iinstead of a syntactic match in the equation for argument0. This enables evaluating terms withI ==Int 0in the path condition.-1and widen requires in equation for negative arguments (previouslyI <Int -1, nowI <Int 0). The result is the same as before with no extra equation required.