Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Homebrew after running commands #3768

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Clean up Homebrew after running commands #3768

merged 1 commit into from
Oct 27, 2023

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Oct 27, 2023

The M2 runner has a stateful Homebrew setup, and so we need to explicitly uninstall and untap the things we have installed and tapped during the release process.

@Baltoli Baltoli requested a review from a team as a code owner October 27, 2023 17:29
@Baltoli Baltoli requested a review from F-WRunTime October 27, 2023 17:29
@rv-jenkins rv-jenkins merged commit 8e0528b into develop Oct 27, 2023
8 checks passed
@rv-jenkins rv-jenkins deleted the brew-clean branch October 27, 2023 18:03
Baltoli added a commit that referenced this pull request Oct 30, 2023
rv-jenkins pushed a commit that referenced this pull request Oct 30, 2023
This PR reverts a series of experimental changes I made last week to
attempt a fix for the flakiness of the macOS Homebrew job; the required
implementation turned out to be substantially trickier than I'd thought
and so this PR undoes the changes in the interest of returning the
release job to a better state. The PRs reverted are:
* #3764
* #3766
* #3767
* #3768

Additionally, I have temporarily disabled the PL-tutorial tests on Intel
macOS to avoid a common source of release flakiness.

Future changes to the Homebrew code should review and adapt the changes
made and reverted here.
@Baltoli Baltoli mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants