Revert experimental Homebrew changes #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
requested review from
dwightguth,
tothtamas28,
goodlyrottenapple,
Robertorosmaninho and
F-WRunTime
goodlyrottenapple
approved these changes
Oct 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a series of experimental changes I made last week to attempt a fix for the flakiness of the macOS Homebrew job; the required implementation turned out to be substantially trickier than I'd thought and so this PR undoes the changes in the interest of returning the release job to a better state. The PRs reverted are:
Additionally, I have temporarily disabled the PL-tutorial tests on Intel macOS to avoid a common source of release flakiness.
Future changes to the Homebrew code should review and adapt the changes made and reverted here.